Daniel Borkmann says: ==================== pull-request: bpf 2022-04-27 We've added 5 non-merge commits during the last 20 day(s) which contain a total of 6 files changed, 34 insertions(+), 12 deletions(-). The main changes are: 1) Fix xsk sockets when rx and tx are separately bound to the same umem, also fix xsk copy mode combined with busy poll, from Maciej Fijalkowski. 2) Fix BPF tunnel/collect_md helpers with bpf_xmit lwt hook usage which triggered a crash due to invalid metadata_dst access, from Eyal Birger. 3) Fix release of page pool in XDP live packet mode, from Toke Høiland-Jørgensen. 4) Fix potential NULL pointer dereference in kretprobes, from Adam Zabrocki. (Masami & Steven preferred this small fix to be routed via bpf tree given it's follow-up fix to Masami's rethook work that went via bpf earlier, too.) * https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf: xsk: Fix possible crash when multiple sockets are created kprobes: Fix KRETPROBES when CONFIG_KRETPROBE_ON_RETHOOK is set bpf, lwt: Fix crash when using bpf_skb_set_tunnel_key() from bpf_xmit lwt hook bpf: Fix release of page_pool in BPF_PROG_RUN in test runner xsk: Fix l2fwd for copy mode + busy poll combo ====================
Showing the changes to kernel (1 of 6 files). Show all
Unified · Split
| @@ -2126,7 +2126,7 @@ static void kretprobe_rethook_handler(struct rethook_node *rh, void *data, · 2125 unmodified lines | ||
| 2126 | 2126 | struct kprobe_ctlblk *kcb; |
| 2127 | 2127 | |
| 2128 | 2128 | /* The data must NOT be null. This means rethook data structure is broken. */ |
| 2129 | − if (WARN_ON_ONCE(!data)) | |
| 2129 | + if (WARN_ON_ONCE(!data) || !rp->handler) | |
| 2130 | 2130 | return; |
| 2131 | 2131 | |
| 2132 | 2132 | __this_cpu_write(current_kprobe, &rp->kp); |