History

ARM: orion/mvebu: unify debug-ll virtual addresses

In a multiplatform configuration, enabling DEBUG_LL breaks booting on all platforms with incompatible settings. In case of the Marvell platforms of the Orion/MVEBU family, the physical addresses are all the same, we just map them at different virtual addresses, which makes it impossible to run a kernel with DEBUG_LL enabled on a combination of the merged mvebu and the legacy boardfile based platforms. This is easily solved by using the same virtual address everywhere. I picked the address that is already used by mach-mvebu for UART0: 0xfec12000. All these platforms have a 1MB region with their internal registers, almost always at physical address 0xf1000000, so I'm updating the iotable for that entry. In case of mach-dove, this is slightly trickier, as the existing mapping is 8MB and a second 8MB mapping is already at the 0xfec00000 address. I have verified from the datasheet that the last 7MB of the physical mapping are "reserved" and nothing in Linux tries to use it either. I'm putting this 1MB mapping at the same address as the others, and the second 8MB register area immediately before that.

Arnd Bergmann committed 7 years ago

Commit 3584be91 parent ce781794 files · +10 −13Browse files

Unified · Split

4 files
  1. arch/arm/Kconfig.debug +1 −4
  2. arch/arm/mach-dove/dove.h +5 −5
  3. arch/arm/mach-mv78xx0/mv78xx0.h +2 −2
  4. arch/arm/mach-orion5x/orion5x.h +2 −2
arch/arm/Kconfig.debug+1−4
@@ -1760,10 +1760,7 @@ config DEBUG_UART_VIRT · 1759 unmodified lines
17601760 default 0xfc705000 if DEBUG_ZTE_ZX
17611761 default 0xfcfe8600 if DEBUG_BCM63XX_UART
17621762 default 0xfd000000 if DEBUG_SPEAR3XX || DEBUG_SPEAR13XX
1763− default 0xfd012000 if DEBUG_MVEBU_UART0_ALTERNATE && ARCH_MV78XX0
17641763 default 0xfd883000 if DEBUG_ALPINE_UART0
1765− default 0xfde12000 if DEBUG_MVEBU_UART0_ALTERNATE && ARCH_DOVE
1766− default 0xfe012000 if DEBUG_MVEBU_UART0_ALTERNATE && ARCH_ORION5X
17671764 default 0xfe017000 if DEBUG_MMP_UART2
17681765 default 0xfe018000 if DEBUG_MMP_UART3
17691766 default 0xfe100000 if DEBUG_IMX23_UART || DEBUG_IMX28_UART
@@ -1778,7 +1775,7 @@ config DEBUG_UART_VIRT · 8 unmodified lines
17781775 default 0xfec02000 if DEBUG_SOCFPGA_UART0
17791776 default 0xfec02100 if DEBUG_SOCFPGA_ARRIA10_UART1
17801777 default 0xfec03000 if DEBUG_SOCFPGA_CYCLONE5_UART1
1781− default 0xfec12000 if (DEBUG_MVEBU_UART0 || DEBUG_MVEBU_UART0_ALTERNATE) && ARCH_MVEBU
1778+ default 0xfec12000 if DEBUG_MVEBU_UART0 || DEBUG_MVEBU_UART0_ALTERNATE
17821779 default 0xfec12100 if DEBUG_MVEBU_UART1_ALTERNATE
17831780 default 0xfec10000 if DEBUG_SIRFATLAS7_UART0
17841781 default 0xfec20000 if DEBUG_DAVINCI_DMx_UART0
arch/arm/mach-dove/dove.h+5−5
@@ -18,8 +18,8 @@ · 17 unmodified lines
1818 * c8000000 fdb00000 1M Cryptographic SRAM
1919 * e0000000 @runtime 128M PCIe-0 Memory space
2020 * e8000000 @runtime 128M PCIe-1 Memory space
21− * f1000000 fde00000 8M on-chip south-bridge registers
22− * f1800000 fe600000 8M on-chip north-bridge registers
21+ * f1000000 fec00000 1M on-chip south-bridge registers
22+ * f1800000 fe400000 8M on-chip north-bridge registers
2323 * f2000000 fee00000 1M PCIe-0 I/O space
2424 * f2100000 fef00000 1M PCIe-1 I/O space
2525 */
@@ -42,11 +42,11 @@ · 16 unmodified lines
4242 #define DOVE_SCRATCHPAD_SIZE SZ_1M
4343
4444 #define DOVE_SB_REGS_PHYS_BASE 0xf1000000
45−#define DOVE_SB_REGS_VIRT_BASE IOMEM(0xfde00000)
46−#define DOVE_SB_REGS_SIZE SZ_8M
45+#define DOVE_SB_REGS_VIRT_BASE IOMEM(0xfec00000)
46+#define DOVE_SB_REGS_SIZE SZ_1M
4747
4848 #define DOVE_NB_REGS_PHYS_BASE 0xf1800000
49−#define DOVE_NB_REGS_VIRT_BASE IOMEM(0xfe600000)
49+#define DOVE_NB_REGS_VIRT_BASE IOMEM(0xfe400000)
5050 #define DOVE_NB_REGS_SIZE SZ_8M
5151
5252 #define DOVE_PCIE0_IO_PHYS_BASE 0xf2000000
arch/arm/mach-mv78xx0/mv78xx0.h+2−2
@@ -37,7 +37,7 @@ · 36 unmodified lines
3737 * fee50000 f0d00000 64K PCIe #5 I/O space
3838 * fee60000 f0e00000 64K PCIe #6 I/O space
3939 * fee70000 f0f00000 64K PCIe #7 I/O space
40− * fd000000 f1000000 1M on-chip peripheral registers
40+ * fec00000 f1000000 1M on-chip peripheral registers
4141 */
4242 #define MV78XX0_CORE0_REGS_PHYS_BASE 0xf1020000
4343 #define MV78XX0_CORE1_REGS_PHYS_BASE 0xf1024000
@@ -49,7 +49,7 @@ · 5 unmodified lines
4949 #define MV78XX0_PCIE_IO_SIZE SZ_1M
5050
5151 #define MV78XX0_REGS_PHYS_BASE 0xf1000000
52−#define MV78XX0_REGS_VIRT_BASE IOMEM(0xfd000000)
52+#define MV78XX0_REGS_VIRT_BASE IOMEM(0xfec00000)
5353 #define MV78XX0_REGS_SIZE SZ_1M
5454
5555 #define MV78XX0_PCIE_MEM_PHYS_BASE 0xc0000000
arch/arm/mach-orion5x/orion5x.h+2−2
@@ -31,13 +31,13 @@ · 30 unmodified lines
3131 * fc000000 device bus mappings (cs0/cs1)
3232 *
3333 * virt phys size
34− * fe000000 f1000000 1M on-chip peripheral registers
34+ * fec00000 f1000000 1M on-chip peripheral registers
3535 * fee00000 f2000000 64K PCIe I/O space
3636 * fee10000 f2100000 64K PCI I/O space
3737 * fd000000 f0000000 16M PCIe WA space (Orion-1/Orion-NAS only)
3838 ****************************************************************************/
3939 #define ORION5X_REGS_PHYS_BASE 0xf1000000
40−#define ORION5X_REGS_VIRT_BASE IOMEM(0xfe000000)
40+#define ORION5X_REGS_VIRT_BASE IOMEM(0xfec00000)
4141 #define ORION5X_REGS_SIZE SZ_1M
4242
4343 #define ORION5X_PCIE_IO_PHYS_BASE 0xf2000000

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t