The problem arises if an entity in sysfs is created and removed without ever having been made completely visible. In SCSI this is triggered by removing a device while it's initialising. The problem appears to be that because it was never made visible in sysfs, the sysfs dentry has a null d_inode which oopses when a reference is made to it. The solution is simply to check d_inode and assume the object was never made visible (and thus doesn't need deleting) if it's NULL. (akpm: possibly a stopgap for 2.6.13 scsi problems. May not be the long-term fix)
Unified · Split
| @@ -228,6 +228,10 @@ void sysfs_hash_and_remove(struct dentry * dir, const char * name) · 227 unmodified lines | |||
| 228 | struct sysfs_dirent * sd; | 228 | struct sysfs_dirent * sd; |
| 229 | struct sysfs_dirent * parent_sd = dir->d_fsdata; | 229 | struct sysfs_dirent * parent_sd = dir->d_fsdata; |
| 230 | 230 | ||
| 231 | if (dir->d_inode == NULL) | ||
| 232 | /* no inode means this hasn't been made visible yet */ | ||
| 233 | return; | ||
| 234 | |||
| 231 | down(&dir->d_inode->i_sem); | 235 | down(&dir->d_inode->i_sem); |
| 232 | list_for_each_entry(sd, &parent_sd->s_children, s_sibling) { | 236 | list_for_each_entry(sd, &parent_sd->s_children, s_sibling) { |
| 233 | if (!sd->s_element) | 237 | if (!sd->s_element) |