History

xfrm Fix potential error pointer dereference in xfrm_bundle_create.

We may derference an invalid pointer in the error path of xfrm_bundle_create(). Fix this by returning this error pointer directly instead of assigning it to xdst0.

Steffen Klassert committed 8 years ago

Commit 38369f51 parent d9f92771 file · +2 −3Browse files

Unified · Split

net/xfrm/xfrm_policy.c+2−3
@@ -1658,7 +1658,6 @@ static struct dst_entry *xfrm_bundle_create(struct xfrm_policy *policy, · 1657 unmodified lines
16581658 trailer_len -= xdst_prev->u.dst.xfrm->props.trailer_len;
16591659 }
16601660
1661−out:
16621661 return &xdst0->u.dst;
16631662
16641663 put_states:
@@ -1667,8 +1666,8 @@ put_states: · 2 unmodified lines
16671666 free_dst:
16681667 if (xdst0)
16691668 dst_release_immediate(&xdst0->u.dst);
1670− xdst0 = ERR_PTR(err);
1671− goto out;
1669+
1670+ return ERR_PTR(err);
16721671 }
16731672
16741673 static int xfrm_expand_policies(const struct flowi *fl, u16 family,

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t