History

libperf: Add perf_cpu_map__get()/perf_cpu_map__put()

Moving the following functions: cpu_map__get() cpu_map__put() to libperf with following names: perf_cpu_map__get() perf_cpu_map__put() Committer notes: Added fixes for arm/arm64

Jiri Olsa committed 7 years ago

Commit 38f01d81 parent 397721e33 files · +78 −75Browse files

Unified · Split

33 files
  1. tools/perf/arch/arm/util/cs-etm.c +3 −3
  2. tools/perf/arch/arm64/util/header.c +2 −2
  3. tools/perf/builtin-ftrace.c +1 −1
  4. tools/perf/builtin-stat.c +2 −2
  5. tools/perf/lib/cpumap.c +24 −0
  6. tools/perf/lib/include/perf/cpumap.h +2 −0
  7. tools/perf/lib/libperf.map +2 −0
  8. tools/perf/tests/bitmap.c +1 −1
  9. tools/perf/tests/code-reading.c +2 −2
  10. tools/perf/tests/cpumap.c +4 −4
  11. tools/perf/tests/event-times.c +2 −2
  12. tools/perf/tests/event_update.c +2 −2
  13. tools/perf/tests/keep-tracking.c +1 −1
  14. tools/perf/tests/mem2node.c +1 −1
  15. tools/perf/tests/mmap-basic.c +1 −1
  16. tools/perf/tests/openat-syscall-all-cpus.c +1 −1
  17. tools/perf/tests/sw-clock.c +1 −1
  18. tools/perf/tests/switch-tracking.c +1 −1
  19. tools/perf/tests/task-exit.c +1 −1
  20. tools/perf/tests/topology.c +1 −1
  21. tools/perf/util/cpumap.c +0 −22
  22. tools/perf/util/cpumap.h +0 −3
  23. tools/perf/util/cputopo.c +2 −2
  24. tools/perf/util/env.c +1 −1
  25. tools/perf/util/event.c +1 −1
  26. tools/perf/util/evlist.c +8 −8
  27. tools/perf/util/evsel.c +2 −2
  28. tools/perf/util/parse-events.c +2 −2
  29. tools/perf/util/pmu.c +1 −1
  30. tools/perf/util/python.c +1 −1
  31. tools/perf/util/record.c +3 −3
  32. tools/perf/util/session.c +1 −1
  33. tools/perf/util/svghelper.c +1 −1
tools/perf/arch/arm/util/cs-etm.c+3−3
@@ -181,7 +181,7 @@ static int cs_etm_set_option(struct auxtrace_record *itr, · 180 unmodified lines
181181
182182 err = 0;
183183 out:
184− cpu_map__put(online_cpus);
184+ perf_cpu_map__put(online_cpus);
185185 return err;
186186 }
187187
@@ -517,7 +517,7 @@ cs_etm_info_priv_size(struct auxtrace_record *itr __maybe_unused, · 329 unmodified lines
517517 }
518518 }
519519
520− cpu_map__put(online_cpus);
520+ perf_cpu_map__put(online_cpus);
521521
522522 return (CS_ETM_HEADER_SIZE +
523523 (etmv4 * CS_ETMV4_PRIV_SIZE) +
@@ -679,7 +679,7 @@ static int cs_etm_info_fill(struct auxtrace_record *itr, · 155 unmodified lines
679679 if (cpu_map__has(cpu_map, i))
680680 cs_etm_get_metadata(i, &offset, itr, info);
681681
682− cpu_map__put(online_cpus);
682+ perf_cpu_map__put(online_cpus);
683683
684684 return 0;
685685 }
tools/perf/arch/arm64/util/header.c+2−2
@@ -27,7 +27,7 @@ char *get_cpuid_str(struct perf_pmu *pmu) · 26 unmodified lines
2727 return NULL;
2828
2929 /* read midr from list of cpus mapped to this pmu */
30− cpus = cpu_map__get(pmu->cpus);
30+ cpus = perf_cpu_map__get(pmu->cpus);
3131 for (cpu = 0; cpu < cpus->nr; cpu++) {
3232 scnprintf(path, PATH_MAX, "%s/devices/system/cpu/cpu%d"MIDR,
3333 sysfs, cpus->map[cpu]);
@@ -60,6 +60,6 @@ char *get_cpuid_str(struct perf_pmu *pmu) · 26 unmodified lines
6060 buf = NULL;
6161 }
6262
63− cpu_map__put(cpus);
63+ perf_cpu_map__put(cpus);
6464 return buf;
6565 }
tools/perf/builtin-ftrace.c+1−1
@@ -206,7 +206,7 @@ static int reset_tracing_cpu(void) · 205 unmodified lines
206206 int ret;
207207
208208 ret = set_tracing_cpumask(cpumap);
209− cpu_map__put(cpumap);
209+ perf_cpu_map__put(cpumap);
210210 return ret;
211211 }
212212
tools/perf/builtin-stat.c+2−2
@@ -933,8 +933,8 @@ static int perf_stat_init_aggr_mode(void) · 932 unmodified lines
933933
934934 static void perf_stat__exit_aggr_mode(void)
935935 {
936− cpu_map__put(stat_config.aggr_map);
937− cpu_map__put(stat_config.cpus_aggr_map);
936+ perf_cpu_map__put(stat_config.aggr_map);
937+ perf_cpu_map__put(stat_config.cpus_aggr_map);
938938 stat_config.aggr_map = NULL;
939939 stat_config.cpus_aggr_map = NULL;
940940 }
tools/perf/lib/cpumap.c+24−0
@@ -3,6 +3,8 @@ · 2 unmodified lines
33 #include <stdlib.h>
44 #include <linux/refcount.h>
55 #include <internal/cpumap.h>
6+#include <asm/bug.h>
7+#include <stdio.h>
68
79 struct perf_cpu_map *perf_cpu_map__dummy_new(void)
810 {
@@ -16,3 +18,25 @@ struct perf_cpu_map *perf_cpu_map__dummy_new(void) · 7 unmodified lines
1618
1719 return cpus;
1820 }
21+
22+static void cpu_map__delete(struct perf_cpu_map *map)
23+{
24+ if (map) {
25+ WARN_ONCE(refcount_read(&map->refcnt) != 0,
26+ "cpu_map refcnt unbalanced\n");
27+ free(map);
28+ }
29+}
30+
31+struct perf_cpu_map *perf_cpu_map__get(struct perf_cpu_map *map)
32+{
33+ if (map)
34+ refcount_inc(&map->refcnt);
35+ return map;
36+}
37+
38+void perf_cpu_map__put(struct perf_cpu_map *map)
39+{
40+ if (map && refcount_dec_and_test(&map->refcnt))
41+ cpu_map__delete(map);
42+}
tools/perf/lib/include/perf/cpumap.h+2−0
@@ -7,5 +7,7 @@ · 6 unmodified lines
77 struct perf_cpu_map;
88
99 LIBPERF_API struct perf_cpu_map *perf_cpu_map__dummy_new(void);
10+LIBPERF_API struct perf_cpu_map *perf_cpu_map__get(struct perf_cpu_map *map);
11+LIBPERF_API void perf_cpu_map__put(struct perf_cpu_map *map);
1012
1113 #endif /* __LIBPERF_CPUMAP_H */
tools/perf/lib/libperf.map+2−0
@@ -2,6 +2,8 @@ LIBPERF_0.0.1 { · 1 unmodified line
22 global:
33 libperf_set_print;
44 perf_cpu_map__dummy_new;
5+ perf_cpu_map__get;
6+ perf_cpu_map__put;
57 local:
68 *;
79 };
tools/perf/tests/bitmap.c+1−1
@@ -21,7 +21,7 @@ static unsigned long *get_bitmap(const char *str, int nbits) · 20 unmodified lines
2121 }
2222
2323 if (map)
24− cpu_map__put(map);
24+ perf_cpu_map__put(map);
2525 return bm;
2626 }
2727
tools/perf/tests/code-reading.c+2−2
@@ -655,7 +655,7 @@ static int do_test_code_reading(bool try_kcore) · 654 unmodified lines
655655 * and will be freed by following perf_evlist__set_maps
656656 * call. Getting refference to keep them alive.
657657 */
658− cpu_map__get(cpus);
658+ perf_cpu_map__get(cpus);
659659 thread_map__get(threads);
660660 perf_evlist__set_maps(evlist, NULL, NULL);
661661 evlist__delete(evlist);
@@ -705,7 +705,7 @@ out_err: · 43 unmodified lines
705705 if (evlist) {
706706 evlist__delete(evlist);
707707 } else {
708− cpu_map__put(cpus);
708+ perf_cpu_map__put(cpus);
709709 thread_map__put(threads);
710710 }
711711 machine__delete_threads(machine);
tools/perf/tests/cpumap.c+4−4
@@ -39,7 +39,7 @@ static int process_event_mask(struct perf_tool *tool __maybe_unused, · 38 unmodified lines
3939 TEST_ASSERT_VAL("wrong cpu", map->map[i] == i);
4040 }
4141
42− cpu_map__put(map);
42+ perf_cpu_map__put(map);
4343 return 0;
4444 }
4545
@@ -68,7 +68,7 @@ static int process_event_cpus(struct perf_tool *tool __maybe_unused, · 22 unmodified lines
6868 TEST_ASSERT_VAL("wrong cpu", map->map[0] == 1);
6969 TEST_ASSERT_VAL("wrong cpu", map->map[1] == 256);
7070 TEST_ASSERT_VAL("wrong refcnt", refcount_read(&map->refcnt) == 1);
71− cpu_map__put(map);
71+ perf_cpu_map__put(map);
7272 return 0;
7373 }
7474
@@ -83,7 +83,7 @@ int test__cpu_map_synthesize(struct test *test __maybe_unused, int subtest __may · 8 unmodified lines
8383 TEST_ASSERT_VAL("failed to synthesize map",
8484 !perf_event__synthesize_cpu_map(NULL, cpus, process_event_mask, NULL));
8585
86− cpu_map__put(cpus);
86+ perf_cpu_map__put(cpus);
8787
8888 /* This one is better stores in cpu values. */
8989 cpus = cpu_map__new("1,256");
@@ -91,7 +91,7 @@ int test__cpu_map_synthesize(struct test *test __maybe_unused, int subtest __may · 1 unmodified line
9191 TEST_ASSERT_VAL("failed to synthesize map",
9292 !perf_event__synthesize_cpu_map(NULL, cpus, process_event_cpus, NULL));
9393
94− cpu_map__put(cpus);
94+ perf_cpu_map__put(cpus);
9595 return 0;
9696 }
9797
tools/perf/tests/event-times.c+2−2
@@ -132,7 +132,7 @@ static int attach__cpu_disabled(struct evlist *evlist) · 131 unmodified lines
132132 return err;
133133 }
134134
135− cpu_map__put(cpus);
135+ perf_cpu_map__put(cpus);
136136 return evsel__enable(evsel);
137137 }
138138
@@ -154,7 +154,7 @@ static int attach__cpu_enabled(struct evlist *evlist) · 15 unmodified lines
154154 if (err == -EACCES)
155155 return TEST_SKIP;
156156
157− cpu_map__put(cpus);
157+ perf_cpu_map__put(cpus);
158158 return err ? TEST_FAIL : TEST_OK;
159159 }
160160
tools/perf/tests/event_update.c+2−2
@@ -73,7 +73,7 @@ static int process_event_cpus(struct perf_tool *tool __maybe_unused, · 72 unmodified lines
7373 TEST_ASSERT_VAL("wrong cpus", map->map[0] == 1);
7474 TEST_ASSERT_VAL("wrong cpus", map->map[1] == 2);
7575 TEST_ASSERT_VAL("wrong cpus", map->map[2] == 3);
76− cpu_map__put(map);
76+ perf_cpu_map__put(map);
7777 return 0;
7878 }
7979
@@ -113,6 +113,6 @@ int test__event_update(struct test *test __maybe_unused, int subtest __maybe_unu · 33 unmodified lines
113113 TEST_ASSERT_VAL("failed to synthesize attr update cpus",
114114 !perf_event__synthesize_event_update_cpus(&tmp.tool, evsel, process_event_cpus));
115115
116− cpu_map__put(evsel->own_cpus);
116+ perf_cpu_map__put(evsel->own_cpus);
117117 return 0;
118118 }
tools/perf/tests/keep-tracking.c+1−1
@@ -149,7 +149,7 @@ out_err: · 148 unmodified lines
149149 evlist__disable(evlist);
150150 evlist__delete(evlist);
151151 } else {
152− cpu_map__put(cpus);
152+ perf_cpu_map__put(cpus);
153153 thread_map__put(threads);
154154 }
155155
tools/perf/tests/mem2node.c+1−1
@@ -32,7 +32,7 @@ static unsigned long *get_bitmap(const char *str, int nbits) · 31 unmodified lines
3232 }
3333
3434 if (map)
35− cpu_map__put(map);
35+ perf_cpu_map__put(map);
3636 else
3737 free(bm);
3838
tools/perf/tests/mmap-basic.c+1−1
@@ -155,7 +155,7 @@ out_delete_evlist: · 154 unmodified lines
155155 cpus = NULL;
156156 threads = NULL;
157157 out_free_cpus:
158− cpu_map__put(cpus);
158+ perf_cpu_map__put(cpus);
159159 out_free_threads:
160160 thread_map__put(threads);
161161 return err;
tools/perf/tests/openat-syscall-all-cpus.c+1−1
@@ -120,7 +120,7 @@ out_close_fd: · 119 unmodified lines
120120 out_evsel_delete:
121121 evsel__delete(evsel);
122122 out_cpu_map_delete:
123− cpu_map__put(cpus);
123+ perf_cpu_map__put(cpus);
124124 out_thread_map_delete:
125125 thread_map__put(threads);
126126 return err;
tools/perf/tests/sw-clock.c+1−1
@@ -125,7 +125,7 @@ out_init: · 124 unmodified lines
125125 }
126126
127127 out_free_maps:
128− cpu_map__put(cpus);
128+ perf_cpu_map__put(cpus);
129129 thread_map__put(threads);
130130 out_delete_evlist:
131131 evlist__delete(evlist);
tools/perf/tests/switch-tracking.c+1−1
@@ -569,7 +569,7 @@ out: · 568 unmodified lines
569569 evlist__disable(evlist);
570570 evlist__delete(evlist);
571571 } else {
572− cpu_map__put(cpus);
572+ perf_cpu_map__put(cpus);
573573 thread_map__put(threads);
574574 }
575575
tools/perf/tests/task-exit.c+1−1
@@ -135,7 +135,7 @@ out_init: · 134 unmodified lines
135135 }
136136
137137 out_free_maps:
138− cpu_map__put(cpus);
138+ perf_cpu_map__put(cpus);
139139 thread_map__put(threads);
140140 out_delete_evlist:
141141 evlist__delete(evlist);
tools/perf/tests/topology.c+1−1
@@ -133,7 +133,7 @@ int test__session_topology(struct test *test __maybe_unused, int subtest __maybe · 132 unmodified lines
133133 }
134134
135135 ret = check_cpu_topology(path, map);
136− cpu_map__put(map);
136+ perf_cpu_map__put(map);
137137
138138 free_path:
139139 unlink(path);
tools/perf/util/cpumap.c+0−22
@@ -273,28 +273,6 @@ struct perf_cpu_map *cpu_map__empty_new(int nr) · 272 unmodified lines
273273 return cpus;
274274 }
275275
276−static void cpu_map__delete(struct perf_cpu_map *map)
277−{
278− if (map) {
279− WARN_ONCE(refcount_read(&map->refcnt) != 0,
280− "cpu_map refcnt unbalanced\n");
281− free(map);
282− }
283−}
284−
285−struct perf_cpu_map *cpu_map__get(struct perf_cpu_map *map)
286−{
287− if (map)
288− refcount_inc(&map->refcnt);
289− return map;
290−}
291−
292−void cpu_map__put(struct perf_cpu_map *map)
293−{
294− if (map && refcount_dec_and_test(&map->refcnt))
295− cpu_map__delete(map);
296−}
297−
298276 static int cpu__get_topology_int(int cpu, const char *name, int *value)
299277 {
300278 char path[PATH_MAX];
tools/perf/util/cpumap.h+0−3
@@ -29,9 +29,6 @@ int cpu_map__build_die_map(struct perf_cpu_map *cpus, struct perf_cpu_map **diep · 28 unmodified lines
2929 int cpu_map__build_core_map(struct perf_cpu_map *cpus, struct perf_cpu_map **corep);
3030 const struct perf_cpu_map *cpu_map__online(void); /* thread unsafe */
3131
32−struct perf_cpu_map *cpu_map__get(struct perf_cpu_map *map);
33−void cpu_map__put(struct perf_cpu_map *map);
34−
3532 static inline int cpu_map__socket(struct perf_cpu_map *sock, int s)
3633 {
3734 if (!sock || s > sock->nr || s < 0)
tools/perf/util/cputopo.c+2−2
@@ -219,7 +219,7 @@ struct cpu_topology *cpu_topology__new(void) · 218 unmodified lines
219219 }
220220
221221 out_free:
222− cpu_map__put(map);
222+ perf_cpu_map__put(map);
223223 if (ret) {
224224 cpu_topology__delete(tp);
225225 tp = NULL;
@@ -335,7 +335,7 @@ struct numa_topology *numa_topology__new(void) · 109 unmodified lines
335335 out:
336336 free(buf);
337337 fclose(fp);
338− cpu_map__put(node_map);
338+ perf_cpu_map__put(node_map);
339339 return tp;
340340 }
341341
tools/perf/util/env.c+1−1
@@ -179,7 +179,7 @@ void perf_env__exit(struct perf_env *env) · 178 unmodified lines
179179 zfree(&env->cpu);
180180
181181 for (i = 0; i < env->nr_numa_nodes; i++)
182− cpu_map__put(env->numa_nodes[i].map);
182+ perf_cpu_map__put(env->numa_nodes[i].map);
183183 zfree(&env->numa_nodes);
184184
185185 for (i = 0; i < env->caches_cnt; i++)
tools/perf/util/event.c+1−1
@@ -1403,7 +1403,7 @@ size_t perf_event__fprintf_cpu_map(union perf_event *event, FILE *fp) · 1402 unmodified lines
14031403 else
14041404 ret += fprintf(fp, "failed to get cpumap from event\n");
14051405
1406− cpu_map__put(cpus);
1406+ perf_cpu_map__put(cpus);
14071407 return ret;
14081408 }
14091409
tools/perf/util/evlist.c+8−8
@@ -141,7 +141,7 @@ void evlist__delete(struct evlist *evlist) · 140 unmodified lines
141141
142142 perf_evlist__munmap(evlist);
143143 evlist__close(evlist);
144− cpu_map__put(evlist->cpus);
144+ perf_cpu_map__put(evlist->cpus);
145145 thread_map__put(evlist->threads);
146146 evlist->cpus = NULL;
147147 evlist->threads = NULL;
@@ -158,11 +158,11 @@ static void __perf_evlist__propagate_maps(struct evlist *evlist, · 10 unmodified lines
158158 * keep it, if there's no target cpu list defined.
159159 */
160160 if (!evsel->own_cpus || evlist->has_user_cpus) {
161− cpu_map__put(evsel->cpus);
162− evsel->cpus = cpu_map__get(evlist->cpus);
161+ perf_cpu_map__put(evsel->cpus);
162+ evsel->cpus = perf_cpu_map__get(evlist->cpus);
163163 } else if (evsel->cpus != evsel->own_cpus) {
164− cpu_map__put(evsel->cpus);
165− evsel->cpus = cpu_map__get(evsel->own_cpus);
164+ perf_cpu_map__put(evsel->cpus);
165+ evsel->cpus = perf_cpu_map__get(evsel->own_cpus);
166166 }
167167
168168 thread_map__put(evsel->threads);
@@ -1115,8 +1115,8 @@ void perf_evlist__set_maps(struct evlist *evlist, struct perf_cpu_map *cpus, · 946 unmodified lines
11151115 * the caller to increase the reference count.
11161116 */
11171117 if (cpus != evlist->cpus) {
1118− cpu_map__put(evlist->cpus);
1119− evlist->cpus = cpu_map__get(cpus);
1118+ perf_cpu_map__put(evlist->cpus);
1119+ evlist->cpus = perf_cpu_map__get(cpus);
11201120 }
11211121
11221122 if (threads != evlist->threads) {
@@ -1383,7 +1383,7 @@ static int perf_evlist__create_syswide_maps(struct evlist *evlist) · 260 unmodified lines
13831383 out:
13841384 return err;
13851385 out_put:
1386− cpu_map__put(cpus);
1386+ perf_cpu_map__put(cpus);
13871387 goto out;
13881388 }
13891389
tools/perf/util/evsel.c+2−2
@@ -1325,8 +1325,8 @@ void perf_evsel__exit(struct evsel *evsel) · 1324 unmodified lines
13251325 perf_evsel__free_id(evsel);
13261326 perf_evsel__free_config_terms(evsel);
13271327 cgroup__put(evsel->cgrp);
1328− cpu_map__put(evsel->cpus);
1329− cpu_map__put(evsel->own_cpus);
1328+ perf_cpu_map__put(evsel->cpus);
1329+ perf_cpu_map__put(evsel->own_cpus);
13301330 thread_map__put(evsel->threads);
13311331 zfree(&evsel->group_name);
13321332 zfree(&evsel->name);
tools/perf/util/parse-events.c+2−2
@@ -332,8 +332,8 @@ __add_event(struct list_head *list, int *idx, · 331 unmodified lines
332332 return NULL;
333333
334334 (*idx)++;
335− evsel->cpus = cpu_map__get(cpus);
336− evsel->own_cpus = cpu_map__get(cpus);
335+ evsel->cpus = perf_cpu_map__get(cpus);
336+ evsel->own_cpus = perf_cpu_map__get(cpus);
337337 evsel->system_wide = pmu ? pmu->is_uncore : false;
338338 evsel->auto_merge_stats = auto_merge_stats;
339339
tools/perf/util/pmu.c+1−1
@@ -626,7 +626,7 @@ static bool pmu_is_uncore(const char *name) · 625 unmodified lines
626626
627627 snprintf(path, PATH_MAX, CPUS_TEMPLATE_UNCORE, sysfs, name);
628628 cpus = __pmu_cpumask(path);
629− cpu_map__put(cpus);
629+ perf_cpu_map__put(cpus);
630630
631631 return !!cpus;
632632 }
tools/perf/util/python.c+1−1
@@ -557,7 +557,7 @@ static int pyrf_cpu_map__init(struct pyrf_cpu_map *pcpus, · 556 unmodified lines
557557
558558 static void pyrf_cpu_map__delete(struct pyrf_cpu_map *pcpus)
559559 {
560− cpu_map__put(pcpus->cpus);
560+ perf_cpu_map__put(pcpus->cpus);
561561 Py_TYPE(pcpus)->tp_free((PyObject*)pcpus);
562562 }
563563
tools/perf/util/record.c+3−3
@@ -67,7 +67,7 @@ static bool perf_probe_api(setup_probe_fn_t fn) · 66 unmodified lines
6767 if (!cpus)
6868 return false;
6969 cpu = cpus->map[0];
70− cpu_map__put(cpus);
70+ perf_cpu_map__put(cpus);
7171
7272 do {
7373 ret = perf_do_probe_api(fn, cpu, try[i++]);
@@ -122,7 +122,7 @@ bool perf_can_record_cpu_wide(void) · 48 unmodified lines
122122 if (!cpus)
123123 return false;
124124 cpu = cpus->map[0];
125− cpu_map__put(cpus);
125+ perf_cpu_map__put(cpus);
126126
127127 fd = sys_perf_event_open(&attr, -1, cpu, -1, 0);
128128 if (fd < 0)
@@ -278,7 +278,7 @@ bool perf_evlist__can_select_event(struct evlist *evlist, const char *str) · 149 unmodified lines
278278 struct perf_cpu_map *cpus = cpu_map__new(NULL);
279279
280280 cpu = cpus ? cpus->map[0] : 0;
281− cpu_map__put(cpus);
281+ perf_cpu_map__put(cpus);
282282 } else {
283283 cpu = evlist->cpus->map[0];
284284 }
tools/perf/util/session.c+1−1
@@ -2310,7 +2310,7 @@ int perf_session__cpu_bitmap(struct perf_session *session, · 2309 unmodified lines
23102310 err = 0;
23112311
23122312 out_delete_map:
2313− cpu_map__put(map);
2313+ perf_cpu_map__put(map);
23142314 return err;
23152315 }
23162316
tools/perf/util/svghelper.c+1−1
@@ -745,7 +745,7 @@ static int str_to_bitmap(char *s, cpumask_t *b) · 744 unmodified lines
745745 set_bit(c, cpumask_bits(b));
746746 }
747747
748− cpu_map__put(m);
748+ perf_cpu_map__put(m);
749749
750750 return ret;
751751 }

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t