This was an oversight in the original implementation, as it makes no sense to specify both scoping flags to the same openat2(2) invocation (before this patch, the result of such an invocation was equivalent to RESOLVE_IN_ROOT being ignored). This is a userspace-visible ABI change, but the only user of openat2(2) at the moment is LXC which doesn't specify both flags and so no userspace programs will break as a result.
Unified · Split
| @@ -1010,6 +1010,10 @@ inline int build_open_flags(const struct open_how *how, struct open_flags *op) · 1009 unmodified lines | |||
| 1010 | if (how->resolve & ~VALID_RESOLVE_FLAGS) | 1010 | if (how->resolve & ~VALID_RESOLVE_FLAGS) |
| 1011 | return -EINVAL; | 1011 | return -EINVAL; |
| 1012 | 1012 | ||
| 1013 | /* Scoping flags are mutually exclusive. */ | ||
| 1014 | if ((how->resolve & RESOLVE_BENEATH) && (how->resolve & RESOLVE_IN_ROOT)) | ||
| 1015 | return -EINVAL; | ||
| 1016 | |||
| 1013 | /* Deal with the mode. */ | 1017 | /* Deal with the mode. */ |
| 1014 | if (WILL_CREATE(flags)) { | 1018 | if (WILL_CREATE(flags)) { |
| 1015 | if (how->mode & ~S_IALLUGO) | 1019 | if (how->mode & ~S_IALLUGO) |