History

ftrace: Remove return value of ftrace_arch_modify_*()

All instances of the function ftrace_arch_modify_prepare() and ftrace_arch_modify_post_process() return zero. There's no point in checking their return value. Just have them be void functions. Link: https://lkml.kernel.org/r/20220518023639.4065-1-kunyu@nfschina.com

Li kunyu committed 4 years ago

Commit 3a2bfec1 parent 2decd166 files · +13 −28Browse files

Showing the changes to kernel/trace (1 of 6 files). Show all

Unified · Split

kernel/trace/ftrace.c+4−12
@@ -2704,18 +2704,16 @@ ftrace_nop_initialize(struct module *mod, struct dyn_ftrace *rec) · 2703 unmodified lines
2704 * archs can override this function if they must do something2704 * archs can override this function if they must do something
2705 * before the modifying code is performed.2705 * before the modifying code is performed.
2706 */2706 */
2707int __weak ftrace_arch_code_modify_prepare(void)2707void __weak ftrace_arch_code_modify_prepare(void)
2708{2708{
2709 return 0;
2710}2709}
2711 2710
2712/*2711/*
2713 * archs can override this function if they must do something2712 * archs can override this function if they must do something
2714 * after the modifying code is performed.2713 * after the modifying code is performed.
2715 */2714 */
2716int __weak ftrace_arch_code_modify_post_process(void)2715void __weak ftrace_arch_code_modify_post_process(void)
2717{2716{
2718 return 0;
2719}2717}
2720 2718
2721void ftrace_modify_all_code(int command)2719void ftrace_modify_all_code(int command)
@@ -2801,12 +2799,7 @@ void __weak arch_ftrace_update_code(int command) · 79 unmodified lines
2801 2799
2802static void ftrace_run_update_code(int command)2800static void ftrace_run_update_code(int command)
2803{2801{
2804 int ret;2802 ftrace_arch_code_modify_prepare();
2805
2806 ret = ftrace_arch_code_modify_prepare();
2807 FTRACE_WARN_ON(ret);
2808 if (ret)
2809 return;
2810 2803
2811 /*2804 /*
2812 * By default we use stop_machine() to modify the code.2805 * By default we use stop_machine() to modify the code.
@@ -2816,8 +2809,7 @@ static void ftrace_run_update_code(int command) · 3 unmodified lines
2816 */2809 */
2817 arch_ftrace_update_code(command);2810 arch_ftrace_update_code(command);
2818 2811
2819 ret = ftrace_arch_code_modify_post_process();2812 ftrace_arch_code_modify_post_process();
2820 FTRACE_WARN_ON(ret);
2821}2813}
2822 2814
2823static void ftrace_run_modify_code(struct ftrace_ops *ops, int command,2815static void ftrace_run_modify_code(struct ftrace_ops *ops, int command,