History

btrfs: drop devid as device_list_add() arg

As struct btrfs_disk_super is being passed, so it can get devid the same way its parent does.

Anand Jain committed 8 years ago

Commit 3acbcbf1 parent e124ece1 file · +3 −5Browse files

Unified · Split

fs/btrfs/volumes.c+3−5
@@ -728,12 +728,13 @@ error_brelse: · 727 unmodified lines
728728 * error pointer when failed
729729 */
730730 static noinline struct btrfs_device *device_list_add(const char *path,
731− struct btrfs_super_block *disk_super, u64 devid)
731+ struct btrfs_super_block *disk_super)
732732 {
733733 struct btrfs_device *device;
734734 struct btrfs_fs_devices *fs_devices;
735735 struct rcu_string *name;
736736 u64 found_transid = btrfs_super_generation(disk_super);
737+ u64 devid = btrfs_stack_device_id(&disk_super->dev_item);
737738
738739 fs_devices = find_fsid(disk_super->fsid);
739740 if (!fs_devices) {
@@ -1181,7 +1182,6 @@ int btrfs_scan_one_device(const char *path, fmode_t flags, void *holder, · 441 unmodified lines
11811182 struct block_device *bdev;
11821183 struct page *page;
11831184 int ret = 0;
1184− u64 devid;
11851185 u64 bytenr;
11861186
11871187 /*
@@ -1205,9 +1205,7 @@ int btrfs_scan_one_device(const char *path, fmode_t flags, void *holder, · 17 unmodified lines
12051205 goto error_bdev_put;
12061206 }
12071207
1208− devid = btrfs_stack_device_id(&disk_super->dev_item);
1209−
1210− device = device_list_add(path, disk_super, devid);
1208+ device = device_list_add(path, disk_super);
12111209 if (IS_ERR(device))
12121210 ret = PTR_ERR(device);
12131211 else