binary_sysctl(): fix memory leak

binary_sysctl() calls sysctl_getname() which allocates from names_cache slab usin __getname() The matching function to free the name is __putname(), and not putname() which should be used only to match getname() allocations. This is because when auditing is enabled, putname() calls audit_putname *instead* (not in addition) to __putname(). Then, if a syscall is in progress, audit_putname does not release the name - instead, it expects the name to get released when the syscall completes, but that will happen only if audit_getname() was called previously, i.e. if the name was allocated with getname() rather than the naked __getname(). So, __getname() followed by putname() ends up leaking memory.

Michel Lespinasse committed 14 years ago

Commit 3d3c8f91 parent 00065261 file · +1 −1Browse files

Showing the changes to kernel/sysctl_binary.c (1 of 1 file). Show all

Unified · Split

kernel/sysctl_binary.c+1−1

@@ -1354,7 +1354,7 @@ static ssize_t binary_sysctl(const int *name, int nlen, · 1353 unmodified lines
1354		1354
1355	fput(file);	1355	fput(file);
1356	out_putname:	1356	out_putname:
1357	putname(pathname);	1357	__putname(pathname);
1358	out:	1358	out:
1359	return result;	1359	return result;
1360	}	1360	}