The invocation of softirq is now handled by irq_exit(), so there is no need for sparc64 to invoke it on the trap-return path. In fact, doing so is a bug because if the trap occurred in the idle loop, this invocation can result in lockdep-RCU failures. The problem is that RCU ignores idle CPUs, and the sparc64 trap-return path to the softirq handlers fails to tell RCU that the CPU must be considered non-idle while those handlers are executing. This means that RCU is ignoring any RCU read-side critical sections in those handlers, which in turn means that RCU-protected data can be yanked out from under those read-side critical sections. The shiny new lockdep-RCU ability to detect RCU read-side critical sections that RCU is ignoring located this problem. The fix is straightforward: Make sparc64 stop manually invoking the softirq handlers.
Unified · Split
| @@ -20,11 +20,6 @@ · 19 unmodified lines | |||
| 20 | 20 | ||
| 21 | .text | 21 | .text |
| 22 | .align 32 | 22 | .align 32 |
| 23 | __handle_softirq: | ||
| 24 | call do_softirq | ||
| 25 | nop | ||
| 26 | ba,a,pt %xcc, __handle_softirq_continue | ||
| 27 | nop | ||
| 28 | __handle_preemption: | 23 | __handle_preemption: |
| 29 | call schedule | 24 | call schedule |
| 30 | wrpr %g0, RTRAP_PSTATE, %pstate | 25 | wrpr %g0, RTRAP_PSTATE, %pstate |
| @@ -89,9 +84,7 @@ rtrap: · 58 unmodified lines | |||
| 89 | cmp %l1, 0 | 84 | cmp %l1, 0 |
| 90 | 85 | ||
| 91 | /* mm/ultra.S:xcall_report_regs KNOWS about this load. */ | 86 | /* mm/ultra.S:xcall_report_regs KNOWS about this load. */ |
| 92 | bne,pn %icc, __handle_softirq | ||
| 93 | ldx [%sp + PTREGS_OFF + PT_V9_TSTATE], %l1 | 87 | ldx [%sp + PTREGS_OFF + PT_V9_TSTATE], %l1 |
| 94 | __handle_softirq_continue: | ||
| 95 | rtrap_xcall: | 88 | rtrap_xcall: |
| 96 | sethi %hi(0xf << 20), %l4 | 89 | sethi %hi(0xf << 20), %l4 |
| 97 | and %l1, %l4, %l4 | 90 | and %l1, %l4, %l4 |