History

mm: enable maple tree RCU mode by default

Use the maple tree in RCU mode for VMA tracking. The maple tree tracks the stack and is able to update the pivot (lower/upper boundary) in-place to allow the page fault handler to write to the tree while holding just the mmap read lock. This is safe as the writes to the stack have a guard VMA which ensures there will always be a NULL in the direction of the growth and thus will only update a pivot. It is possible, but not recommended, to have VMAs that grow up/down without guard VMAs. syzbot has constructed a testcase which sets up a VMA to grow and consume the empty space. Overwriting the entire NULL entry causes the tree to be altered in a way that is not safe for concurrent readers; the readers may see a node being rewritten or one that does not match the maple state they are using. Enabling RCU mode allows the concurrent readers to see a stable node and will return the expected result. [Liam.Howlett@Oracle.com: we don't need to free the nodes with RCU[ Link: https://lore.kernel.org/linux-mm/000000000000b0a65805f663ace6@google.com/ Link: https://lkml.kernel.org/r/20230227173632.3292573-9-surenb@google.com Fixes: d4af56c5c7c6 ("mm: start tracking VMAs with maple tree") Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com> Signed-off-by: Suren Baghdasaryan <surenb@google.com> Reported-by: syzbot+8d95422d3537159ca390@syzkaller.appspotmail.com Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

Liam R. Howlett committed 3 years ago

Commit 3dd44321 parent 790e1fa3 files · +7 −2Browse files

Showing the changes to include/linux (1 of 3 files). Show all

Unified · Split

include/linux/mm_types.h+2−1
@@ -774,7 +774,8 @@ struct mm_struct { · 773 unmodified lines
774 unsigned long cpu_bitmap[];774 unsigned long cpu_bitmap[];
775};775};
776 776
777#define MM_MT_FLAGS (MT_FLAGS_ALLOC_RANGE | MT_FLAGS_LOCK_EXTERN)777#define MM_MT_FLAGS (MT_FLAGS_ALLOC_RANGE | MT_FLAGS_LOCK_EXTERN | \
778 MT_FLAGS_USE_RCU)
778extern struct mm_struct init_mm;779extern struct mm_struct init_mm;
779 780
780/* Pointer magic because the dynamic array size confuses some compilers. */781/* Pointer magic because the dynamic array size confuses some compilers. */