While trying to debug why my Atom netbook is falling over booting rawhide debug-enabled kernels, I stumbled across the fact that we've been enabling object debugging by default. However, once you default it to on, you've got no way to turn it back off again at runtime. Add a boolean toggle to turn it off. I would just make it an int module_param, however people may already expect the boolean enable behaviour, so just add an analogue for disabling.
Showing the changes to lib/debugobjects.c (1 of 2 files). Show all
Unified · Split
| @@ -55,7 +55,15 @@ static int __init enable_object_debug(char *str) · 54 unmodified lines | |||
| 55 | debug_objects_enabled = 1; | 55 | debug_objects_enabled = 1; |
| 56 | return 0; | 56 | return 0; |
| 57 | } | 57 | } |
| 58 | |||
| 59 | static int __init disable_object_debug(char *str) | ||
| 60 | { | ||
| 61 | debug_objects_enabled = 0; | ||
| 62 | return 0; | ||
| 63 | } | ||
| 64 | |||
| 58 | early_param("debug_objects", enable_object_debug); | 65 | early_param("debug_objects", enable_object_debug); |
| 66 | early_param("no_debug_objects", disable_object_debug); | ||
| 59 | 67 | ||
| 60 | static const char *obj_states[ODEBUG_STATE_MAX] = { | 68 | static const char *obj_states[ODEBUG_STATE_MAX] = { |
| 61 | [ODEBUG_STATE_NONE] = "none", | 69 | [ODEBUG_STATE_NONE] = "none", |