History

genirq/affinity: Use get/put_online_cpus around cpumask operations

Without locking out CPU mask operations we might end up with an inconsistent view of the cpumask in the function.

Christoph Hellwig committed 10 years ago

Commit 3ee0ce21 parent 4396f461 file · +2 −0Browse files

Unified · Split

kernel/irq/affinity.c+2−0
@@ -39,6 +39,7 @@ struct cpumask *irq_create_affinity_mask(unsigned int *nr_vecs) · 38 unmodified lines
39 return NULL;39 return NULL;
40 }40 }
41 41
42 get_online_cpus();
42 if (max_vecs >= num_online_cpus()) {43 if (max_vecs >= num_online_cpus()) {
43 cpumask_copy(affinity_mask, cpu_online_mask);44 cpumask_copy(affinity_mask, cpu_online_mask);
44 *nr_vecs = num_online_cpus();45 *nr_vecs = num_online_cpus();
@@ -56,6 +57,7 @@ struct cpumask *irq_create_affinity_mask(unsigned int *nr_vecs) · 11 unmodified lines
56 }57 }
57 *nr_vecs = vecs;58 *nr_vecs = vecs;
58 }59 }
60 put_online_cpus();
59 61
60 return affinity_mask;62 return affinity_mask;
61}63}

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t