History

net: dsa: mv88e6xxx: Fix masking of egress port

Add missing ~ to the usage of the mask.

Andrew Lunn committed 6 years ago

Commit 3ee339e1 parent ac004e81 file · +2 −2Browse files

Unified · Split

drivers/net/dsa/mv88e6xxx/global1.c+2−2
@@ -278,13 +278,13 @@ int mv88e6095_g1_set_egress_port(struct mv88e6xxx_chip *chip, · 277 unmodified lines
278 switch (direction) {278 switch (direction) {
279 case MV88E6XXX_EGRESS_DIR_INGRESS:279 case MV88E6XXX_EGRESS_DIR_INGRESS:
280 dest_port_chip = &chip->ingress_dest_port;280 dest_port_chip = &chip->ingress_dest_port;
281 reg &= MV88E6185_G1_MONITOR_CTL_INGRESS_DEST_MASK;281 reg &= ~MV88E6185_G1_MONITOR_CTL_INGRESS_DEST_MASK;
282 reg |= port <<282 reg |= port <<
283 __bf_shf(MV88E6185_G1_MONITOR_CTL_INGRESS_DEST_MASK);283 __bf_shf(MV88E6185_G1_MONITOR_CTL_INGRESS_DEST_MASK);
284 break;284 break;
285 case MV88E6XXX_EGRESS_DIR_EGRESS:285 case MV88E6XXX_EGRESS_DIR_EGRESS:
286 dest_port_chip = &chip->egress_dest_port;286 dest_port_chip = &chip->egress_dest_port;
287 reg &= MV88E6185_G1_MONITOR_CTL_EGRESS_DEST_MASK;287 reg &= ~MV88E6185_G1_MONITOR_CTL_EGRESS_DEST_MASK;
288 reg |= port <<288 reg |= port <<
289 __bf_shf(MV88E6185_G1_MONITOR_CTL_EGRESS_DEST_MASK);289 __bf_shf(MV88E6185_G1_MONITOR_CTL_EGRESS_DEST_MASK);
290 break;290 break;