History

drm/amdgpu: Fix even more out of bound writes from debugfs

CVE-2021-42327 was fixed by: commit f23750b5b3d98653b31d4469592935ef6364ad67 Author: Thelford Williams <tdwilliamsiv@gmail.com> Date: Wed Oct 13 16:04:13 2021 -0400 drm/amdgpu: fix out of bounds write but amdgpu_dm_debugfs.c contains more of the same issue so fix the remaining ones. v2: * Add missing fix in dp_max_bpc_write (Harry Wentland)

Patrik Jakobsson committed 5 years ago

Commit 3f4e54b1 parent defbbcd1 file · +9 −9Browse files

Showing the changes to drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c (1 of 1 file). Show all

Unified · Split

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c+9−9
@@ -487,7 +487,7 @@ static ssize_t dp_phy_settings_write(struct file *f, const char __user *buf, · 486 unmodified lines
487487 if (!wr_buf)
488488 return -ENOSPC;
489489
490− if (parse_write_buffer_into_params(wr_buf, size,
490+ if (parse_write_buffer_into_params(wr_buf, wr_buf_size,
491491 (long *)param, buf,
492492 max_param_num,
493493 &param_nums)) {
@@ -639,7 +639,7 @@ static ssize_t dp_phy_test_pattern_debugfs_write(struct file *f, const char __us · 145 unmodified lines
639639 if (!wr_buf)
640640 return -ENOSPC;
641641
642− if (parse_write_buffer_into_params(wr_buf, size,
642+ if (parse_write_buffer_into_params(wr_buf, wr_buf_size,
643643 (long *)param, buf,
644644 max_param_num,
645645 &param_nums)) {
@@ -914,7 +914,7 @@ static ssize_t dp_dsc_passthrough_set(struct file *f, const char __user *buf, · 268 unmodified lines
914914 return -ENOSPC;
915915 }
916916
917− if (parse_write_buffer_into_params(wr_buf, size,
917+ if (parse_write_buffer_into_params(wr_buf, wr_buf_size,
918918 &param, buf,
919919 max_param_num,
920920 &param_nums)) {
@@ -1211,7 +1211,7 @@ static ssize_t trigger_hotplug(struct file *f, const char __user *buf, · 290 unmodified lines
12111211 return -ENOSPC;
12121212 }
12131213
1214− if (parse_write_buffer_into_params(wr_buf, size,
1214+ if (parse_write_buffer_into_params(wr_buf, wr_buf_size,
12151215 (long *)param, buf,
12161216 max_param_num,
12171217 &param_nums)) {
@@ -1396,7 +1396,7 @@ static ssize_t dp_dsc_clock_en_write(struct file *f, const char __user *buf, · 178 unmodified lines
13961396 return -ENOSPC;
13971397 }
13981398
1399− if (parse_write_buffer_into_params(wr_buf, size,
1399+ if (parse_write_buffer_into_params(wr_buf, wr_buf_size,
14001400 (long *)param, buf,
14011401 max_param_num,
14021402 &param_nums)) {
@@ -1581,7 +1581,7 @@ static ssize_t dp_dsc_slice_width_write(struct file *f, const char __user *buf, · 178 unmodified lines
15811581 return -ENOSPC;
15821582 }
15831583
1584− if (parse_write_buffer_into_params(wr_buf, size,
1584+ if (parse_write_buffer_into_params(wr_buf, wr_buf_size,
15851585 (long *)param, buf,
15861586 max_param_num,
15871587 &param_nums)) {
@@ -1766,7 +1766,7 @@ static ssize_t dp_dsc_slice_height_write(struct file *f, const char __user *buf, · 178 unmodified lines
17661766 return -ENOSPC;
17671767 }
17681768
1769− if (parse_write_buffer_into_params(wr_buf, size,
1769+ if (parse_write_buffer_into_params(wr_buf, wr_buf_size,
17701770 (long *)param, buf,
17711771 max_param_num,
17721772 &param_nums)) {
@@ -1944,7 +1944,7 @@ static ssize_t dp_dsc_bits_per_pixel_write(struct file *f, const char __user *bu · 171 unmodified lines
19441944 return -ENOSPC;
19451945 }
19461946
1947− if (parse_write_buffer_into_params(wr_buf, size,
1947+ if (parse_write_buffer_into_params(wr_buf, wr_buf_size,
19481948 (long *)param, buf,
19491949 max_param_num,
19501950 &param_nums)) {
@@ -2382,7 +2382,7 @@ static ssize_t dp_max_bpc_write(struct file *f, const char __user *buf, · 431 unmodified lines
23822382 return -ENOSPC;
23832383 }
23842384
2385− if (parse_write_buffer_into_params(wr_buf, size,
2385+ if (parse_write_buffer_into_params(wr_buf, wr_buf_size,
23862386 (long *)param, buf,
23872387 max_param_num,
23882388 &param_nums)) {

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t