History

sparc64: Ensure perf can access user stacks

When an interrupt (such as a perf counter interrupt) is delivered while executing in user space, the trap entry code puts ASI_AIUS in %asi so that copy_from_user() and copy_to_user() will access the correct memory. But if a perf counter interrupt is delivered while the cpu is already executing in kernel space, then the trap entry code will put ASI_P in %asi, and this will prevent copy_from_user() from reading any useful stack data in either of the perf_callchain_user_X functions, and thus no user callgraph data will be collected for this sample period. An additional problem is that a fault is guaranteed to occur, and though it will be silently covered up, it wastes time and could perturb state. In perf_callchain_user(), we ensure that %asi contains ASI_AIUS because we know for a fact that the subsequent calls to copy_from_user() are intended to read the user's stack. [ Use get_fs()/set_fs() -DaveM ]

Rob Gardner committed 10 years ago

Commit 3f743061 parent 1ca04a41 file · +7 −0Browse files

Unified · Split

arch/sparc/kernel/perf_event.c+7−0
@@ -1828,11 +1828,16 @@ static void perf_callchain_user_32(struct perf_callchain_entry *entry, · 1827 unmodified lines
18281828 void
18291829 perf_callchain_user(struct perf_callchain_entry *entry, struct pt_regs *regs)
18301830 {
1831+ mm_segment_t old_fs;
1832+
18311833 perf_callchain_store(entry, regs->tpc);
18321834
18331835 if (!current->mm)
18341836 return;
18351837
1838+ old_fs = get_fs();
1839+ set_fs(USER_DS);
1840+
18361841 flushw_user();
18371842
18381843 pagefault_disable();
@@ -1843,4 +1848,6 @@ perf_callchain_user(struct perf_callchain_entry *entry, struct pt_regs *regs) · 4 unmodified lines
18431848 perf_callchain_user_64(entry, regs);
18441849
18451850 pagefault_enable();
1851+
1852+ set_fs(old_fs);
18461853 }