We copied the virtio_iommu_config from the virtio-iommu specification, which declares the fields using little-endian annotations (for example le32). Unfortunately this causes sparse to warn about comparison between little- and cpu-endian, because of the typecheck() in virtio_cread(): drivers/iommu/virtio-iommu.c:1024:9: sparse: sparse: incompatible types in comparison expression (different base types): drivers/iommu/virtio-iommu.c:1024:9: sparse: restricted __le64 * drivers/iommu/virtio-iommu.c:1024:9: sparse: unsigned long long * drivers/iommu/virtio-iommu.c:1036:9: sparse: sparse: incompatible types in comparison expression (different base types): drivers/iommu/virtio-iommu.c:1036:9: sparse: restricted __le64 * drivers/iommu/virtio-iommu.c:1036:9: sparse: unsigned long long * drivers/iommu/virtio-iommu.c:1040:9: sparse: sparse: incompatible types in comparison expression (different base types): drivers/iommu/virtio-iommu.c:1040:9: sparse: restricted __le64 * drivers/iommu/virtio-iommu.c:1040:9: sparse: unsigned long long * drivers/iommu/virtio-iommu.c:1044:9: sparse: sparse: incompatible types in comparison expression (different base types): drivers/iommu/virtio-iommu.c:1044:9: sparse: restricted __le32 * drivers/iommu/virtio-iommu.c:1044:9: sparse: unsigned int * drivers/iommu/virtio-iommu.c:1048:9: sparse: sparse: incompatible types in comparison expression (different base types): drivers/iommu/virtio-iommu.c:1048:9: sparse: restricted __le32 * drivers/iommu/virtio-iommu.c:1048:9: sparse: unsigned int * drivers/iommu/virtio-iommu.c:1052:9: sparse: sparse: incompatible types in comparison expression (different base types): drivers/iommu/virtio-iommu.c:1052:9: sparse: restricted __le32 * drivers/iommu/virtio-iommu.c:1052:9: sparse: unsigned int * Although virtio_cread() does convert virtio-endian (in our case little-endian) to cpu-endian, the typecheck() needs the two arguments to have the same endianness. Do as UAPI headers of other virtio devices do, and remove the endian annotation from the device config. Even though we change the UAPI this shouldn't cause any regression since QEMU, the existing implementation of virtio-iommu that uses this header, already removes the annotations when importing headers.
Showing the changes to include/uapi/linux (1 of 1 file). Show all
Unified · Split
| @@ -18,24 +18,24 @@ · 17 unmodified lines | ||
| 18 | 18 | #define VIRTIO_IOMMU_F_MMIO 5 |
| 19 | 19 | |
| 20 | 20 | struct virtio_iommu_range_64 { |
| 21 | − __le64 start; | |
| 22 | − __le64 end; | |
| 21 | + __u64 start; | |
| 22 | + __u64 end; | |
| 23 | 23 | }; |
| 24 | 24 | |
| 25 | 25 | struct virtio_iommu_range_32 { |
| 26 | − __le32 start; | |
| 27 | − __le32 end; | |
| 26 | + __u32 start; | |
| 27 | + __u32 end; | |
| 28 | 28 | }; |
| 29 | 29 | |
| 30 | 30 | struct virtio_iommu_config { |
| 31 | 31 | /* Supported page sizes */ |
| 32 | − __le64 page_size_mask; | |
| 32 | + __u64 page_size_mask; | |
| 33 | 33 | /* Supported IOVA range */ |
| 34 | 34 | struct virtio_iommu_range_64 input_range; |
| 35 | 35 | /* Max domain ID size */ |
| 36 | 36 | struct virtio_iommu_range_32 domain_range; |
| 37 | 37 | /* Probe buffer size */ |
| 38 | − __le32 probe_size; | |
| 38 | + __u32 probe_size; | |
| 39 | 39 | }; |
| 40 | 40 | |
| 41 | 41 | /* Request types */ |