History

drm/i915: Simplify i915_reg_read_ioctl

Convert to use the freshly available made INTEL_GEN_MASK for easier grepping and improve function readability and clarify the UABI documentation. No functional changes. v2: - Lift GEM_BUG_ONs and use is_power_of_2 (Chris) - Retain -EINVAL on bad flags behavior (Chris) v3: - Extract flags with 'entry->size - 1' (Chris) v4: - Add GEM_BUG_ON on for flags vs entry offset (Chris) v5: - Use 'u16' to match 'dev_priv' (Ville) v6: - Fix checkpatch.pl errors

Joonas Lahtinen committed 9 years ago

Commit 3fd3a6f1 parent fe52e592 files · +48 −53Browse files

Showing the changes to include/uapi (1 of 2 files). Show all

Unified · Split

include/uapi/drm/i915_drm.h+4−2
@@ -1308,14 +1308,16 @@ struct drm_i915_reg_read { · 1307 unmodified lines
13081308 * be specified
13091309 */
13101310 __u64 offset;
1311+#define I915_REG_READ_8B_WA BIT(0)
1312+
13111313 __u64 val; /* Return value */
13121314 };
13131315 /* Known registers:
13141316 *
13151317 * Render engine timestamp - 0x2358 + 64bit - gen7+
13161318 * - Note this register returns an invalid value if using the default
1317− * single instruction 8byte read, in order to workaround that use
1318− * offset (0x2538 | 1) instead.
1319+ * single instruction 8byte read, in order to workaround that pass
1320+ * flag I915_REG_READ_8B_WA in offset field.
13191321 *
13201322 */
13211323

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t