SYSCTL_WRITES_WARN was added in commit f4aacea2f5d1 ("sysctl: allow for strict write position handling"), and released in v3.16 in August of 2014. Since then I can find only 1 instance of non-zero offset writing[1], and it was fixed immediately in CRIU[2]. As such, it appears safe to flip this to the strict state now. [1] https://www.google.com/search?q="when%20file%20position%20was%20not%200" [2] http://lists.openvz.org/pipermail/criu/2015-April/019819.html
Showing the changes to kernel/sysctl.c (1 of 2 files). Show all
Unified · Split
| @@ -173,7 +173,7 @@ extern int no_unaligned_warning; · 172 unmodified lines | |||
| 173 | #define SYSCTL_WRITES_WARN 0 | 173 | #define SYSCTL_WRITES_WARN 0 |
| 174 | #define SYSCTL_WRITES_STRICT 1 | 174 | #define SYSCTL_WRITES_STRICT 1 |
| 175 | 175 | ||
| 176 | static int sysctl_writes_strict = SYSCTL_WRITES_WARN; | 176 | static int sysctl_writes_strict = SYSCTL_WRITES_STRICT; |
| 177 | 177 | ||
| 178 | static int proc_do_cad_pid(struct ctl_table *table, int write, | 178 | static int proc_do_cad_pid(struct ctl_table *table, int write, |
| 179 | void __user *buffer, size_t *lenp, loff_t *ppos); | 179 | void __user *buffer, size_t *lenp, loff_t *ppos); |