History

phy: rockchip-samsung-dcphy: Discard pm_runtime_put() return value

Passing pm_runtime_put() return value to the callers is not particularly useful. Returning an error code from pm_runtime_put() merely means that it has not queued up a work item to check whether or not the device can be suspended and there are many perfectly valid situations in which that can happen, like after writing "on" to the devices' runtime PM "control" attribute in sysfs for one example. It also happens when the kernel is configured with CONFIG_PM unset. Accordingly, update samsung_mipi_dcphy_exit() to simply discard the return value of pm_runtime_put() and always return success to the caller. This will facilitate a planned change of the pm_runtime_put() return type to void in the future.

Rafael J. Wysocki committed 10 months ago

Commit 455bf7d1 parent 8bb108e1 file · +3 −1Browse files

Unified · Split

drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c+3−1
@@ -1508,7 +1508,9 @@ static int samsung_mipi_dcphy_exit(struct phy *phy) · 1507 unmodified lines
1508{1508{
1509 struct samsung_mipi_dcphy *samsung = phy_get_drvdata(phy);1509 struct samsung_mipi_dcphy *samsung = phy_get_drvdata(phy);
1510 1510
1511 return pm_runtime_put(samsung->dev);1511 pm_runtime_put(samsung->dev);
1512
1513 return 0;
1512}1514}
1513 1515
1514static const struct phy_ops samsung_mipi_dcphy_ops = {1516static const struct phy_ops samsung_mipi_dcphy_ops = {