History

mm/sparsemem: get address to page struct instead of address to pfn

memmap should be the address to page struct instead of address to pfn. As mentioned by David, if system memory and devmem sit within a section, the mismatch address would lead kdump to dump unexpected memory. Since sub-section only works for SPARSEMEM_VMEMMAP, pfn_to_page() is valid to get the page struct address at this point.

Wei Yang committed 6 years ago

Commit 4627d761 parent 0c287591 file · +1 −1Browse files

Unified · Split

mm/sparse.c+1−1
@@ -894,7 +894,7 @@ int __meminit sparse_add_section(int nid, unsigned long start_pfn, · 893 unmodified lines
894 894
895 /* Align memmap to section boundary in the subsection case */895 /* Align memmap to section boundary in the subsection case */
896 if (section_nr_to_pfn(section_nr) != start_pfn)896 if (section_nr_to_pfn(section_nr) != start_pfn)
897 memmap = pfn_to_kaddr(section_nr_to_pfn(section_nr));897 memmap = pfn_to_page(section_nr_to_pfn(section_nr));
898 sparse_init_one_section(ms, section_nr, memmap, ms->usage, 0);898 sparse_init_one_section(ms, section_nr, memmap, ms->usage, 0);
899 899
900 return 0;900 return 0;

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t