History

net/fq_impl: use skb_get_hash instead of skb_get_hash_perturb

This avoids unnecessarily regenerating the skb flow hash

Felix Fietkau committed 6 years ago

Commit 48a54f61 parent 3ff901c2 files · +1 −3Browse files

Showing the changes to include (2 of 2 files). Show all

Unified · Split

2 files
  1. include/net/fq.h +0 −1
  2. include/net/fq_impl.h +1 −2
include/net/fq.h+0−1
@@ -69,7 +69,6 @@ struct fq { · 68 unmodified lines
6969 struct list_head backlogs;
7070 spinlock_t lock;
7171 u32 flows_cnt;
72− siphash_key_t perturbation;
7372 u32 limit;
7473 u32 memory_limit;
7574 u32 memory_usage;
include/net/fq_impl.h+1−2
@@ -108,7 +108,7 @@ begin: · 107 unmodified lines
108108
109109 static u32 fq_flow_idx(struct fq *fq, struct sk_buff *skb)
110110 {
111− u32 hash = skb_get_hash_perturb(skb, &fq->perturbation);
111+ u32 hash = skb_get_hash(skb);
112112
113113 return reciprocal_scale(hash, fq->flows_cnt);
114114 }
@@ -308,7 +308,6 @@ static int fq_init(struct fq *fq, int flows_cnt) · 193 unmodified lines
308308 INIT_LIST_HEAD(&fq->backlogs);
309309 spin_lock_init(&fq->lock);
310310 fq->flows_cnt = max_t(u32, flows_cnt, 1);
311− get_random_bytes(&fq->perturbation, sizeof(fq->perturbation));
312311 fq->quantum = 300;
313312 fq->limit = 8192;
314313 fq->memory_limit = 16 << 20; /* 16 MBytes */

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t