The main motivation to add set_tid to clone3() is CRIU. To restore a process with the same PID/TID CRIU currently uses /proc/sys/kernel/ns_last_pid. It writes the desired (PID - 1) to ns_last_pid and then (quickly) does a clone(). This works most of the time, but it is racy. It is also slow as it requires multiple syscalls. Extending clone3() to support *set_tid makes it possible restore a process using CRIU without accessing /proc/sys/kernel/ns_last_pid and race free (as long as the desired PID/TID is available). This clone3() extension places the same restrictions (CAP_SYS_ADMIN) on clone3() with *set_tid as they are currently in place for ns_last_pid. The original version of this change was using a single value for set_tid. At the 2019 LPC, after presenting set_tid, it was, however, decided to change set_tid to an array to enable setting the PID of a process in multiple PID namespaces at the same time. If a process is created in a PID namespace it is possible to influence the PID inside and outside of the PID namespace. Details also in the corresponding selftest. To create a process with the following PIDs: PID NS level Requested PID 0 (host) 31496 1 42 2 1 For that example the two newly introduced parameters to struct clone_args (set_tid and set_tid_size) would need to be: set_tid[0] = 1; set_tid[1] = 42; set_tid[2] = 31496; set_tid_size = 3; If only the PIDs of the two innermost nested PID namespaces should be defined it would look like this: set_tid[0] = 1; set_tid[1] = 42; set_tid_size = 2; The PID of the newly created process would then be the next available free PID in the PID namespace level 0 (host) and 42 in the PID namespace at level 1 and the PID of the process in the innermost PID namespace would be 1. The set_tid array is used to specify the PID of a process starting from the innermost nested PID namespaces up to set_tid_size PID namespaces. set_tid_size cannot be larger then the current PID namespace level.
Showing the changes to include/linux (3 of 7 files). Show all
Unified · Split
| @@ -124,7 +124,8 @@ extern struct pid *find_vpid(int nr); · 123 unmodified lines | |||
| 124 | extern struct pid *find_get_pid(int nr); | 124 | extern struct pid *find_get_pid(int nr); |
| 125 | extern struct pid *find_ge_pid(int nr, struct pid_namespace *); | 125 | extern struct pid *find_ge_pid(int nr, struct pid_namespace *); |
| 126 | 126 | ||
| 127 | extern struct pid *alloc_pid(struct pid_namespace *ns); | 127 | extern struct pid *alloc_pid(struct pid_namespace *ns, pid_t *set_tid, |
| 128 | size_t set_tid_size); | ||
| 128 | extern void free_pid(struct pid *pid); | 129 | extern void free_pid(struct pid *pid); |
| 129 | extern void disable_pid_allocation(struct pid_namespace *ns); | 130 | extern void disable_pid_allocation(struct pid_namespace *ns); |
| 130 | 131 | ||
| @@ -12,6 +12,8 @@ · 11 unmodified lines | |||
| 12 | #include <linux/ns_common.h> | 12 | #include <linux/ns_common.h> |
| 13 | #include <linux/idr.h> | 13 | #include <linux/idr.h> |
| 14 | 14 | ||
| 15 | /* MAX_PID_NS_LEVEL is needed for limiting size of 'struct pid' */ | ||
| 16 | #define MAX_PID_NS_LEVEL 32 | ||
| 15 | 17 | ||
| 16 | struct fs_pin; | 18 | struct fs_pin; |
| 17 | 19 | ||
| @@ -26,6 +26,9 @@ struct kernel_clone_args { · 25 unmodified lines | |||
| 26 | unsigned long stack; | 26 | unsigned long stack; |
| 27 | unsigned long stack_size; | 27 | unsigned long stack_size; |
| 28 | unsigned long tls; | 28 | unsigned long tls; |
| 29 | pid_t *set_tid; | ||
| 30 | /* Number of elements in *set_tid */ | ||
| 31 | size_t set_tid_size; | ||
| 29 | }; | 32 | }; |
| 30 | 33 | ||
| 31 | /* | 34 | /* |