History

Revert "GTP: add support for flow based tunneling API"

This reverts commit 9ab7e76aefc97a9aa664accb59d6e8dc5e52514a. This patch was committed without maintainer approval and despite a number of unaddressed concerns from review. There are several issues that impede the acceptance of this patch and that make a reversion of this particular instance of these changes the best way forward: i) the patch contains several logically separate changes that would be better served as smaller patches (for review purposes) ii) functionality like the handling of end markers has been introduced without further explanation iii) symmetry between the handling of GTPv0 and GTPv1 has been unnecessarily broken iv) the patchset produces 'broken' packets when extension headers are included v) there are no available userspace tools to allow for testing this functionality vi) there is an unaddressed Coverity report against the patch concering memory leakage vii) most importantly, the patch contains a large amount of superfluous churn that impedes other ongoing work with this driver This patch will be reworked into a series that aligns with other ongoing work and facilitates review.

Jonas Bonn committed 5 years ago

Commit 49ecc581 parent 3dd344e5 files · +144 −398Browse files

Showing the changes to tools/include/uapi/linux (1 of 5 files). Show all

Unified · Split

tools/include/uapi/linux/if_link.h+0−1
@@ -617,7 +617,6 @@ enum { · 616 unmodified lines
617 IFLA_GTP_FD1,617 IFLA_GTP_FD1,
618 IFLA_GTP_PDP_HASHSIZE,618 IFLA_GTP_PDP_HASHSIZE,
619 IFLA_GTP_ROLE,619 IFLA_GTP_ROLE,
620 IFLA_GTP_COLLECT_METADATA,
621 __IFLA_GTP_MAX,620 __IFLA_GTP_MAX,
622};621};
623#define IFLA_GTP_MAX (__IFLA_GTP_MAX - 1)622#define IFLA_GTP_MAX (__IFLA_GTP_MAX - 1)