History

Revert "GTP: add support for flow based tunneling API"

This reverts commit 9ab7e76aefc97a9aa664accb59d6e8dc5e52514a. This patch was committed without maintainer approval and despite a number of unaddressed concerns from review. There are several issues that impede the acceptance of this patch and that make a reversion of this particular instance of these changes the best way forward: i) the patch contains several logically separate changes that would be better served as smaller patches (for review purposes) ii) functionality like the handling of end markers has been introduced without further explanation iii) symmetry between the handling of GTPv0 and GTPv1 has been unnecessarily broken iv) the patchset produces 'broken' packets when extension headers are included v) there are no available userspace tools to allow for testing this functionality vi) there is an unaddressed Coverity report against the patch concering memory leakage vii) most importantly, the patch contains a large amount of superfluous churn that impedes other ongoing work with this driver This patch will be reworked into a series that aligns with other ongoing work and facilitates review.

Jonas Bonn committed 5 years ago

Commit 49ecc581 parent 3dd344e5 files · +144 −398Browse files

Showing the changes to include/uapi (3 of 5 files). Show all

Unified · Split

3 files
  1. include/uapi/linux/gtp.h +0 −12
  2. include/uapi/linux/if_link.h +0 −1
  3. include/uapi/linux/if_tunnel.h +0 −1
include/uapi/linux/gtp.h+0−12
@@ -2,8 +2,6 @@ · 1 unmodified line
22 #ifndef _UAPI_LINUX_GTP_H_
33 #define _UAPI_LINUX_GTP_H_
44
5−#include <linux/types.h>
6−
75 #define GTP_GENL_MCGRP_NAME "gtp"
86
97 enum gtp_genl_cmds {
@@ -36,14 +34,4 @@ enum gtp_attrs { · 26 unmodified lines
3634 };
3735 #define GTPA_MAX (__GTPA_MAX + 1)
3836
39−enum {
40− GTP_METADATA_V1
41−};
42−
43−struct gtpu_metadata {
44− __u8 ver;
45− __u8 flags;
46− __u8 type;
47−};
48−
4937 #endif /* _UAPI_LINUX_GTP_H_ */
include/uapi/linux/if_link.h+0−1
@@ -811,7 +811,6 @@ enum { · 810 unmodified lines
811811 IFLA_GTP_FD1,
812812 IFLA_GTP_PDP_HASHSIZE,
813813 IFLA_GTP_ROLE,
814− IFLA_GTP_COLLECT_METADATA,
815814 __IFLA_GTP_MAX,
816815 };
817816 #define IFLA_GTP_MAX (__IFLA_GTP_MAX - 1)
include/uapi/linux/if_tunnel.h+0−1
@@ -176,7 +176,6 @@ enum { · 175 unmodified lines
176176 #define TUNNEL_VXLAN_OPT __cpu_to_be16(0x1000)
177177 #define TUNNEL_NOCACHE __cpu_to_be16(0x2000)
178178 #define TUNNEL_ERSPAN_OPT __cpu_to_be16(0x4000)
179−#define TUNNEL_GTPU_OPT __cpu_to_be16(0x8000)
180179
181180 #define TUNNEL_OPTIONS_PRESENT \
182181 (TUNNEL_GENEVE_OPT | TUNNEL_VXLAN_OPT | TUNNEL_ERSPAN_OPT)