of_get_flat_dt_subnode_by_name can return negative value in case of error. Assigning the result to unsigned variable and checking if the variable is lesser than zero is incorrect and always false. The patch fixes it by using signed variable to check the result. The problem has been detected using semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci
Unified · Split
| @@ -657,9 +657,12 @@ static int __init fdt_find_uefi_params(unsigned long node, const char *uname, · 656 unmodified lines | ||
| 657 | 657 | } |
| 658 | 658 | |
| 659 | 659 | if (subnode) { |
| 660 | − node = of_get_flat_dt_subnode_by_name(node, subnode); | |
| 661 | − if (node < 0) | |
| 660 | + int err = of_get_flat_dt_subnode_by_name(node, subnode); | |
| 661 | + | |
| 662 | + if (err < 0) | |
| 662 | 663 | return 0; |
| 664 | + | |
| 665 | + node = err; | |
| 663 | 666 | } |
| 664 | 667 | |
| 665 | 668 | return __find_uefi_params(node, info, dt_params[i].params); |