History

drivers/leds/leds-ot200.c: fix error caused by shifted mask

During the development of this driver an in-house register documentation was used. The last week some integration tests were done and this problem was found. It turned out that the released register documentation is wrong. The fix is very simple: shift all masks by one.

Christian Gmeiner committed 13 years ago

Commit 4b949b81 parent 7c342511 file · +7 −7Browse files

Unified · Split

drivers/leds/leds-ot200.c+7−7
@@ -47,37 +47,37 @@ static struct ot200_led leds[] = { · 46 unmodified lines
4747 {
4848 .name = "led_1",
4949 .port = 0x49,
50− .mask = BIT(7),
50+ .mask = BIT(6),
5151 },
5252 {
5353 .name = "led_2",
5454 .port = 0x49,
55− .mask = BIT(6),
55+ .mask = BIT(5),
5656 },
5757 {
5858 .name = "led_3",
5959 .port = 0x49,
60− .mask = BIT(5),
60+ .mask = BIT(4),
6161 },
6262 {
6363 .name = "led_4",
6464 .port = 0x49,
65− .mask = BIT(4),
65+ .mask = BIT(3),
6666 },
6767 {
6868 .name = "led_5",
6969 .port = 0x49,
70− .mask = BIT(3),
70+ .mask = BIT(2),
7171 },
7272 {
7373 .name = "led_6",
7474 .port = 0x49,
75− .mask = BIT(2),
75+ .mask = BIT(1),
7676 },
7777 {
7878 .name = "led_7",
7979 .port = 0x49,
80− .mask = BIT(1),
80+ .mask = BIT(0),
8181 }
8282 };
8383

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t