History

dt-bindings: phy: qcom-qusb2: Fix defaults

The defaults listed in the bindings don't match what the code is actually doing. Presumably existing users care more about keeping existing behavior the same, so change the bindings to match the code in Linux. The "qcom,preemphasis-level" default has been wrong for quite a long time (May 2018). The other two were recently added. As some evidence that these values are wrong, this is from the Linux driver: - qcom,preemphasis-level: sets "PORT_TUNE1", lower 2 bits. Driver programs PORT_TUNE1 to 0x30 by default and (0x30 & 0x3) = 0. - qcom,bias-ctrl-value: sets "PLL_BIAS_CONTROL_2", lower 6 bits. Driver programs PLL_BIAS_CONTROL_2 to 0x20 by default and (0x20 & 0x3f) = 0x20 = 32. - qcom,hsdisc-trim-value: sets "PORT_TUNE2", lower 2 bits. Driver programs PORT_TUNE2 to 0x29 by default and (0x29 & 0x3) = 1.

Douglas Anderson committed 6 years ago

Commit 4bc77b21 parent 2bdfd4f1 file · +3 −3Browse files

Unified · Split

Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml+3−3
@@ -97,7 +97,7 @@ then: · 96 unmodified lines
97 - $ref: /schemas/types.yaml#/definitions/uint3297 - $ref: /schemas/types.yaml#/definitions/uint32
98 - minimum: 098 - minimum: 0
99 maximum: 6399 maximum: 63
100 default: 0100 default: 32
101 101
102 qcom,charge-ctrl-value:102 qcom,charge-ctrl-value:
103 description:103 description:
@@ -130,7 +130,7 @@ then: · 26 unmodified lines
130 - $ref: /schemas/types.yaml#/definitions/uint32130 - $ref: /schemas/types.yaml#/definitions/uint32
131 - minimum: 0131 - minimum: 0
132 maximum: 3132 maximum: 3
133 default: 2133 default: 0
134 134
135 qcom,preemphasis-width:135 qcom,preemphasis-width:
136 description:136 description:
@@ -152,7 +152,7 @@ then: · 15 unmodified lines
152 - $ref: /schemas/types.yaml#/definitions/uint32152 - $ref: /schemas/types.yaml#/definitions/uint32
153 - minimum: 0153 - minimum: 0
154 maximum: 3154 maximum: 3
155 default: 0155 default: 1
156 156
157required:157required:
158 - compatible158 - compatible