In case external PHY is used, we need to take care of embedded PHY. Since there are no methods to disable this PHY from the MAC side and keeping RMII reference clock, we need to suspend it. This patch will reduce electrical noise (PHY is continuing to send FLPs) and power consumption by 0,22W.
Unified · Split
| @@ -158,6 +158,8 @@ · 157 unmodified lines | ||
| 158 | 158 | #define AX_EEPROM_MAGIC 0xdeadbeef |
| 159 | 159 | #define AX_EEPROM_LEN 0x200 |
| 160 | 160 | |
| 161 | +#define AX_EMBD_PHY_ADDR 0x10 | |
| 162 | + | |
| 161 | 163 | /* This structure cannot exceed sizeof(unsigned long [5]) AKA 20 bytes */ |
| 162 | 164 | struct asix_data { |
| 163 | 165 | u8 multi_filter[AX_MCAST_FILTER_SIZE]; |
| @@ -183,6 +185,7 @@ struct asix_common_private { · 19 unmodified lines | ||
| 183 | 185 | struct asix_rx_fixup_info rx_fixup_info; |
| 184 | 186 | struct mii_bus *mdio; |
| 185 | 187 | struct phy_device *phydev; |
| 188 | + struct phy_device *phydev_int; | |
| 186 | 189 | u16 phy_addr; |
| 187 | 190 | bool embd_phy; |
| 188 | 191 | u8 chipcode; |
| @@ -679,6 +679,22 @@ static int ax88772_init_phy(struct usbnet *dev) · 678 unmodified lines | ||
| 679 | 679 | |
| 680 | 680 | phy_attached_info(priv->phydev); |
| 681 | 681 | |
| 682 | + if (priv->embd_phy) | |
| 683 | + return 0; | |
| 684 | + | |
| 685 | + /* In case main PHY is not the embedded PHY and MAC is RMII clock | |
| 686 | + * provider, we need to suspend embedded PHY by keeping PLL enabled | |
| 687 | + * (AX_SWRESET_IPPD == 0). | |
| 688 | + */ | |
| 689 | + priv->phydev_int = mdiobus_get_phy(priv->mdio, AX_EMBD_PHY_ADDR); | |
| 690 | + if (!priv->phydev_int) { | |
| 691 | + netdev_err(dev->net, "Could not find internal PHY\n"); | |
| 692 | + return -ENODEV; | |
| 693 | + } | |
| 694 | + | |
| 695 | + priv->phydev_int->mac_managed_pm = 1; | |
| 696 | + phy_suspend(priv->phydev_int); | |
| 697 | + | |
| 682 | 698 | return 0; |
| 683 | 699 | } |
| 684 | 700 | |
| @@ -734,7 +750,7 @@ static int ax88772_bind(struct usbnet *dev, struct usb_interface *intf) · 49 unmodified lines | ||
| 734 | 750 | return ret; |
| 735 | 751 | |
| 736 | 752 | priv->phy_addr = ret; |
| 737 | − priv->embd_phy = ((priv->phy_addr & 0x1f) == 0x10); | |
| 753 | + priv->embd_phy = ((priv->phy_addr & 0x1f) == AX_EMBD_PHY_ADDR); | |
| 738 | 754 | |
| 739 | 755 | ret = asix_read_cmd(dev, AX_CMD_STATMNGSTS_REG, 0, 0, 1, |
| 740 | 756 | &priv->chipcode, 0); |