'last_psi_total' and 'list' of damos_quota_goal are intended to be used by only the DAMON core layer. Those are mistakenly not marked as private, though. Mark as private.
Showing the changes to include (1 of 1 file). Show all
Unified · Split
| @@ -175,10 +175,8 @@ enum damos_quota_goal_metric { · 174 unmodified lines | |||
| 175 | * @metric: Metric to be used for representing the goal. | 175 | * @metric: Metric to be used for representing the goal. |
| 176 | * @target_value: Target value of @metric to achieve with the tuning. | 176 | * @target_value: Target value of @metric to achieve with the tuning. |
| 177 | * @current_value: Current value of @metric. | 177 | * @current_value: Current value of @metric. |
| 178 | * @last_psi_total: Last measured total PSI | ||
| 179 | * @nid: Node id. | 178 | * @nid: Node id. |
| 180 | * @memcg_id: Memcg id. | 179 | * @memcg_id: Memcg id. |
| 181 | * @list: List head for siblings. | ||
| 182 | * | 180 | * |
| 183 | * Data structure for getting the current score of the quota tuning goal. The | 181 | * Data structure for getting the current score of the quota tuning goal. The |
| 184 | * score is calculated by how close @current_value and @target_value are. Then | 182 | * score is calculated by how close @current_value and @target_value are. Then |
| @@ -201,12 +199,17 @@ struct damos_quota_goal { · 16 unmodified lines | |||
| 201 | unsigned long current_value; | 199 | unsigned long current_value; |
| 202 | /* metric-dependent fields */ | 200 | /* metric-dependent fields */ |
| 203 | union { | 201 | union { |
| 204 | u64 last_psi_total; | ||
| 205 | struct { | 202 | struct { |
| 206 | int nid; | 203 | int nid; |
| 207 | u64 memcg_id; | 204 | u64 memcg_id; |
| 208 | }; | 205 | }; |
| 206 | /* private: */ | ||
| 207 | /* Last measured total PSI */ | ||
| 208 | u64 last_psi_total; | ||
| 209 | |||
| 209 | }; | 210 | }; |
| 211 | /* private: */ | ||
| 212 | /* List head for siblings. */ | ||
| 210 | struct list_head list; | 213 | struct list_head list; |
| 211 | }; | 214 | }; |
| 212 | 215 | ||