History

pwm: bcm2835: Fix NPD in suspend/resume

When 119a508c4dc9 ("pwm: bcm2835: Add support for suspend/resume") was sent out on October 11th,, there was still a call to platform_set_drvdata() which would ensure that the driver private data structure could be used in bcm2835_pwm_{suspend,resume}. A cleanup now merged as commit commit 2ce7b7f6704c ("pwm: bcm2835: Simplify using devm functions") removed that call which would now cause a NPD in bcm2835_pwm_{suspend,resume} as a consequence.

Florian Fainelli committed 3 years ago

Commit 4e7a8db1 parent b85ea951 file · +2 −0Browse files

Unified · Split

drivers/pwm/pwm-bcm2835.c+2−0
@@ -155,6 +155,8 @@ static int bcm2835_pwm_probe(struct platform_device *pdev) · 154 unmodified lines
155155 pc->chip.ops = &bcm2835_pwm_ops;
156156 pc->chip.npwm = 2;
157157
158+ platform_set_drvdata(pdev, pc);
159+
158160 ret = devm_pwmchip_add(&pdev->dev, &pc->chip);
159161 if (ret < 0)
160162 return dev_err_probe(&pdev->dev, ret,

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t