klp_module_coming() is called for every module appearing in the system. It sets obj->mod to a patched module for klp_object obj. Unfortunately it leaves it set even if an error happens later in the function and the patched module is not allowed to be loaded. klp_is_object_loaded() uses obj->mod variable and could currently give a wrong return value. The bug is probably harmless as of now.
Showing the changes to kernel/livepatch (1 of 1 file). Show all
Unified · Split
| @@ -1175,6 +1175,7 @@ err: · 1174 unmodified lines | ||
| 1175 | 1175 | pr_warn("patch '%s' failed for module '%s', refusing to load module '%s'\n", |
| 1176 | 1176 | patch->mod->name, obj->mod->name, obj->mod->name); |
| 1177 | 1177 | mod->klp_alive = false; |
| 1178 | + obj->mod = NULL; | |
| 1178 | 1179 | klp_cleanup_module_patches_limited(mod, patch); |
| 1179 | 1180 | mutex_unlock(&klp_mutex); |
| 1180 | 1181 | |