Knowing whether we need to delay the MAC configuration because a module may have a PHY is useful to phylink to allow NBASE-T modules to work on systems supporting no more than 2.5G speeds. This commit allows us to delay such configuration until after the PHY has been probed by recording the parsed capabilities, and if the module may have a PHY, doing no more until the module_start() notification is called. At that point, we either have a PHY, or we don't. We move the PHY-based setup a little later, and use the PHYs support capabilities rather than the EEPROM parsed capabilities to determine whether we can support the PHY.
Showing the changes to include/linux (1 of 3 files). Show all
Unified · Split
| @@ -533,6 +533,7 @@ struct sfp_upstream_ops { · 532 unmodified lines | |||
| 533 | #if IS_ENABLED(CONFIG_SFP) | 533 | #if IS_ENABLED(CONFIG_SFP) |
| 534 | int sfp_parse_port(struct sfp_bus *bus, const struct sfp_eeprom_id *id, | 534 | int sfp_parse_port(struct sfp_bus *bus, const struct sfp_eeprom_id *id, |
| 535 | unsigned long *support); | 535 | unsigned long *support); |
| 536 | bool sfp_may_have_phy(struct sfp_bus *bus, const struct sfp_eeprom_id *id); | ||
| 536 | void sfp_parse_support(struct sfp_bus *bus, const struct sfp_eeprom_id *id, | 537 | void sfp_parse_support(struct sfp_bus *bus, const struct sfp_eeprom_id *id, |
| 537 | unsigned long *support); | 538 | unsigned long *support); |
| 538 | phy_interface_t sfp_select_interface(struct sfp_bus *bus, | 539 | phy_interface_t sfp_select_interface(struct sfp_bus *bus, |
| @@ -556,6 +557,12 @@ static inline int sfp_parse_port(struct sfp_bus *bus, · 17 unmodified lines | |||
| 556 | return PORT_OTHER; | 557 | return PORT_OTHER; |
| 557 | } | 558 | } |
| 558 | 559 | ||
| 560 | static inline bool sfp_may_have_phy(struct sfp_bus *bus, | ||
| 561 | const struct sfp_eeprom_id *id) | ||
| 562 | { | ||
| 563 | return false; | ||
| 564 | } | ||
| 565 | |||
| 559 | static inline void sfp_parse_support(struct sfp_bus *bus, | 566 | static inline void sfp_parse_support(struct sfp_bus *bus, |
| 560 | const struct sfp_eeprom_id *id, | 567 | const struct sfp_eeprom_id *id, |
| 561 | unsigned long *support) | 568 | unsigned long *support) |