History

KVM: Fix kvm_clear_dirty_log_protect off-by-(minus-)one

Just imaging the case where num_pages < BITS_PER_LONG, then the loop will be skipped while it shouldn't.

Peter Xu committed 7 years ago

Commit 53eac7a1 parent 4ddc9201 file · +2 −2Browse files

Unified · Split

virt/kvm/kvm_main.c+2−2
@@ -1264,8 +1264,8 @@ int kvm_clear_dirty_log_protect(struct kvm *kvm, · 1263 unmodified lines
12641264 return -EFAULT;
12651265
12661266 spin_lock(&kvm->mmu_lock);
1267− for (offset = log->first_page,
1268− i = offset / BITS_PER_LONG, n = log->num_pages / BITS_PER_LONG; n--;
1267+ for (offset = log->first_page, i = offset / BITS_PER_LONG,
1268+ n = DIV_ROUND_UP(log->num_pages, BITS_PER_LONG); n--;
12691269 i++, offset += BITS_PER_LONG) {
12701270 unsigned long mask = *dirty_bitmap_buffer++;
12711271 atomic_long_t *p = (atomic_long_t *) &dirty_bitmap[i];

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t