History

kernel/relay.c: handle alloc_percpu returning NULL in relay_open

alloc_percpu() may return NULL, which means chan->buf may be set to NULL. In that case, when we do *per_cpu_ptr(chan->buf, ...), we dereference an invalid pointer: BUG: Unable to handle kernel data access at 0x7dae0000 Faulting instruction address: 0xc0000000003f3fec ... NIP relay_open+0x29c/0x600 LR relay_open+0x270/0x600 Call Trace: relay_open+0x264/0x600 (unreliable) __blk_trace_setup+0x254/0x600 blk_trace_setup+0x68/0xa0 sg_ioctl+0x7bc/0x2e80 do_vfs_ioctl+0x13c/0x1300 ksys_ioctl+0x94/0x130 sys_ioctl+0x48/0xb0 system_call+0x5c/0x68 Check if alloc_percpu returns NULL. This was found by syzkaller both on x86 and powerpc, and the reproducer it found on powerpc is capable of hitting the issue as an unprivileged user.

Daniel Axtens committed 6 years ago

Commit 54e200a1 parent 67446281 file · +5 −0Browse files

Showing the changes to kernel (1 of 1 file). Show all

Unified · Split

kernel/relay.c+5−0
@@ -581,6 +581,11 @@ struct rchan *relay_open(const char *base_filename, · 580 unmodified lines
581581 return NULL;
582582
583583 chan->buf = alloc_percpu(struct rchan_buf *);
584+ if (!chan->buf) {
585+ kfree(chan);
586+ return NULL;
587+ }
588+
584589 chan->version = RELAYFS_CHANNEL_VERSION;
585590 chan->n_subbufs = n_subbufs;
586591 chan->subbuf_size = subbuf_size;

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t