alloc_percpu() may return NULL, which means chan->buf may be set to NULL. In that case, when we do *per_cpu_ptr(chan->buf, ...), we dereference an invalid pointer: BUG: Unable to handle kernel data access at 0x7dae0000 Faulting instruction address: 0xc0000000003f3fec ... NIP relay_open+0x29c/0x600 LR relay_open+0x270/0x600 Call Trace: relay_open+0x264/0x600 (unreliable) __blk_trace_setup+0x254/0x600 blk_trace_setup+0x68/0xa0 sg_ioctl+0x7bc/0x2e80 do_vfs_ioctl+0x13c/0x1300 ksys_ioctl+0x94/0x130 sys_ioctl+0x48/0xb0 system_call+0x5c/0x68 Check if alloc_percpu returns NULL. This was found by syzkaller both on x86 and powerpc, and the reproducer it found on powerpc is capable of hitting the issue as an unprivileged user.
Showing the changes to kernel (1 of 1 file). Show all
Unified · Split
| @@ -581,6 +581,11 @@ struct rchan *relay_open(const char *base_filename, · 580 unmodified lines | ||
| 581 | 581 | return NULL; |
| 582 | 582 | |
| 583 | 583 | chan->buf = alloc_percpu(struct rchan_buf *); |
| 584 | + if (!chan->buf) { | |
| 585 | + kfree(chan); | |
| 586 | + return NULL; | |
| 587 | + } | |
| 588 | + | |
| 584 | 589 | chan->version = RELAYFS_CHANNEL_VERSION; |
| 585 | 590 | chan->n_subbufs = n_subbufs; |
| 586 | 591 | chan->subbuf_size = subbuf_size; |