History

bpf: add layer 2 encap support to bpf_skb_adjust_room

commit 868d523535c2 ("bpf: add bpf_skb_adjust_room encap flags") introduced support to bpf_skb_adjust_room for GSO-friendly GRE and UDP encapsulation. For GSO to work for skbs, the inner headers (mac and network) need to be marked. For L3 encapsulation using bpf_skb_adjust_room, the mac and network headers are identical. Here we provide a way of specifying the inner mac header length for cases where L2 encap is desired. Such an approach can support encapsulated ethernet headers, MPLS headers etc. For example to convert from a packet of form [eth][ip][tcp] to [eth][ip][udp][inner mac][ip][tcp], something like the following could be done: headroom = sizeof(iph) + sizeof(struct udphdr) + inner_maclen; ret = bpf_skb_adjust_room(skb, headroom, BPF_ADJ_ROOM_MAC, BPF_F_ADJ_ROOM_ENCAP_L4_UDP | BPF_F_ADJ_ROOM_ENCAP_L3_IPV4 | BPF_F_ADJ_ROOM_ENCAP_L2(inner_maclen));

Alan Maguire committed 7 years ago

Commit 58dfc901 parent 166b5a72 files · +18 −4Browse files

Showing the changes to include/uapi/linux (1 of 2 files). Show all

Unified · Split

include/uapi/linux/bpf.h+10−0
@@ -1523,6 +1523,10 @@ union bpf_attr { · 1522 unmodified lines
15231523 * * **BPF_F_ADJ_ROOM_ENCAP_L4_UDP **:
15241524 * Use with ENCAP_L3 flags to further specify the tunnel type.
15251525 *
1526+ * * **BPF_F_ADJ_ROOM_ENCAP_L2(len) **:
1527+ * Use with ENCAP_L3/L4 flags to further specify the tunnel
1528+ * type; **len** is the length of the inner MAC header.
1529+ *
15261530 * A call to this helper is susceptible to change the underlaying
15271531 * packet buffer. Therefore, at load time, all checks on pointers
15281532 * previously done by the verifier are invalidated and must be
@@ -2664,10 +2668,16 @@ enum bpf_func_id { · 1135 unmodified lines
26642668 /* BPF_FUNC_skb_adjust_room flags. */
26652669 #define BPF_F_ADJ_ROOM_FIXED_GSO (1ULL << 0)
26662670
2671+#define BPF_ADJ_ROOM_ENCAP_L2_MASK 0xff
2672+#define BPF_ADJ_ROOM_ENCAP_L2_SHIFT 56
2673+
26672674 #define BPF_F_ADJ_ROOM_ENCAP_L3_IPV4 (1ULL << 1)
26682675 #define BPF_F_ADJ_ROOM_ENCAP_L3_IPV6 (1ULL << 2)
26692676 #define BPF_F_ADJ_ROOM_ENCAP_L4_GRE (1ULL << 3)
26702677 #define BPF_F_ADJ_ROOM_ENCAP_L4_UDP (1ULL << 4)
2678+#define BPF_F_ADJ_ROOM_ENCAP_L2(len) (((__u64)len & \
2679+ BPF_ADJ_ROOM_ENCAP_L2_MASK) \
2680+ << BPF_ADJ_ROOM_ENCAP_L2_SHIFT)
26712681
26722682 /* Mode for BPF_FUNC_skb_adjust_room helper. */
26732683 enum bpf_adj_room_mode {