The description, it may have already been added without a CRC, in this case just update the CRC ... is no longer valid. In the old days, this function was used to update the CRC as well. Commit 040fcc819a2e ("kbuild: improved modversioning support for external modules") started to use a separate function (sym_update_crc) for updating the CRC. The first part, "Add an exported symbol" is correct, but it is too obvious from the function name. Drop this comment entirely.
Showing the changes to scripts (1 of 1 file). Show all
Unified · Split
| @@ -387,10 +387,6 @@ static void sym_update_namespace(const char *symname, const char *namespace) · 386 unmodified lines | |||
| 387 | s->namespace = namespace[0] ? NOFAIL(strdup(namespace)) : NULL; | 387 | s->namespace = namespace[0] ? NOFAIL(strdup(namespace)) : NULL; |
| 388 | } | 388 | } |
| 389 | 389 | ||
| 390 | /** | ||
| 391 | * Add an exported symbol - it may have already been added without a | ||
| 392 | * CRC, in this case just update the CRC | ||
| 393 | **/ | ||
| 394 | static struct symbol *sym_add_exported(const char *name, struct module *mod, | 390 | static struct symbol *sym_add_exported(const char *name, struct module *mod, |
| 395 | enum export export) | 391 | enum export export) |
| 396 | { | 392 | { |