Make sure static, extern, and asmlinkage appear before a specific type. e.g.: int asmlinkage foo(void) is better written asmlinkage int foo(void)
Showing the changes to scripts/checkpatch.pl (1 of 1 file). Show all
Unified · Split
| @@ -5576,10 +5576,18 @@ sub process { · 5575 unmodified lines | |||
| 5576 | "architecture specific defines should be avoided\n" . $herecurr); | 5576 | "architecture specific defines should be avoided\n" . $herecurr); |
| 5577 | } | 5577 | } |
| 5578 | 5578 | ||
| 5579 | # check that the storage class is not after a type | ||
| 5580 | if ($line =~ /\b($Type)\s+($Storage)\b/) { | ||
| 5581 | WARN("STORAGE_CLASS", | ||
| 5582 | "storage class '$2' should be located before type '$1'\n" . $herecurr); | ||
| 5583 | } | ||
| 5579 | # Check that the storage class is at the beginning of a declaration | 5584 | # Check that the storage class is at the beginning of a declaration |
| 5580 | if ($line =~ /\b$Storage\b/ && $line !~ /^.\s*$Storage\b/) { | 5585 | if ($line =~ /\b$Storage\b/ && |
| 5586 | $line !~ /^.\s*$Storage/ && | ||
| 5587 | $line =~ /^.\s*(.+?)\$Storage\s/ && | ||
| 5588 | $1 !~ /[\,\)]\s*$/) { | ||
| 5581 | WARN("STORAGE_CLASS", | 5589 | WARN("STORAGE_CLASS", |
| 5582 | "storage class should be at the beginning of the declaration\n" . $herecurr) | 5590 | "storage class should be at the beginning of the declaration\n" . $herecurr); |
| 5583 | } | 5591 | } |
| 5584 | 5592 | ||
| 5585 | # check the location of the inline attribute, that it is between | 5593 | # check the location of the inline attribute, that it is between |