History

sungem: Fix WakeOnLan

WakeOnLan was broken in this driver because gp->asleep_wol is a 1-bit bitfield and it was being assigned WAKE_MAGIC, which is (1 << 5). gp->asleep_wol remains 0 and the machine never wakes up. Fixed by casting gp->wake_on_lan to bool. Tested on an iBook G4.

Gerard Lledo committed 14 years ago

Commit 5a8887d1 parent b49960a1 file · +1 −1Browse files

Unified · Split

drivers/net/ethernet/sun/sungem.c+1−1
@@ -2339,7 +2339,7 @@ static int gem_suspend(struct pci_dev *pdev, pm_message_t state) · 2338 unmodified lines
2339 netif_device_detach(dev);2339 netif_device_detach(dev);
2340 2340
2341 /* Switch off chip, remember WOL setting */2341 /* Switch off chip, remember WOL setting */
2342 gp->asleep_wol = gp->wake_on_lan;2342 gp->asleep_wol = !!gp->wake_on_lan;
2343 gem_do_stop(dev, gp->asleep_wol);2343 gem_do_stop(dev, gp->asleep_wol);
2344 2344
2345 /* Unlock the network stack */2345 /* Unlock the network stack */

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t