random: move randomize_page() into mm where it belongs

randomize_page is an mm function. It is documented like one. It contains the history of one. It has the naming convention of one. It looks just like another very similar function in mm, randomize_stack_top(). And it has always been maintained and updated by mm people. There is no need for it to be in random.c. In the "which shape does not look like the other ones" test, pointing to randomize_page() is correct. So move randomize_page() into mm/util.c, right next to the similar randomize_stack_top() function. This commit contains no actual code changes.

Jason A. Donenfeld committed 4 years ago

Commit 5ad7dd81 parent 6701de64 files · +33 −34Browse files

Showing the changes to include (2 of 4 files). Show all

Unified · Split

2 files

include/linux/mm.h +1 −0
include/linux/random.h +0 −2

include/linux/mm.h+1−0

@@ -2677,6 +2677,7 @@ extern int install_special_mapping(struct mm_struct *mm, · 2676 unmodified lines
2677	unsigned long flags, struct page **pages);	2677	unsigned long flags, struct page **pages);
2678		2678
2679	unsigned long randomize_stack_top(unsigned long stack_top);	2679	unsigned long randomize_stack_top(unsigned long stack_top);
		2680	unsigned long randomize_page(unsigned long start, unsigned long range);
2680		2681
2681	extern unsigned long get_unmapped_area(struct file *, unsigned long, unsigned long, unsigned long, unsigned long);	2682	extern unsigned long get_unmapped_area(struct file *, unsigned long, unsigned long, unsigned long, unsigned long);
2682		2683

include/linux/random.h+0−2

@@ -72,8 +72,6 @@ static inline unsigned long get_random_canary(void) · 71 unmodified lines
72	return get_random_long() & CANARY_MASK;	72	return get_random_long() & CANARY_MASK;
73	}	73	}
74		74
75	unsigned long randomize_page(unsigned long start, unsigned long range);
76
77	int __init random_init(const char *command_line);	75	int __init random_init(const char *command_line);
78	bool rng_is_initialized(void);	76	bool rng_is_initialized(void);
79	bool rng_has_arch_random(void);	77	bool rng_has_arch_random(void);