History

kbuild: Fix comment in Makefile.lib

KBUILD_MODNAME is not defined for files that are linked into multiple modules, and trying to change reality to match documentation would result in all sorts of trouble. E.g. options for built-in modules would be called either foo_bar.param, foo.param, or bar.param, depending on the configuration. So just change the comment.

Michal Marek committed 14 years ago

Commit 5bb05711 parent 603d8c01 file · +3 −3Browse files

Showing the changes to scripts (1 of 1 file). Show all

Unified · Split

scripts/Makefile.lib+3−3
@@ -93,9 +93,9 @@ obj-dirs := $(addprefix $(obj)/,$(obj-dirs)) · 92 unmodified lines
9393 # already
9494 # $(modname_flags) #defines KBUILD_MODNAME as the name of the module it will
9595 # end up in (or would, if it gets compiled in)
96−# Note: It's possible that one object gets potentially linked into more
97−# than one module. In that case KBUILD_MODNAME will be set to foo_bar,
98−# where foo and bar are the name of the modules.
96+# Note: Files that end up in two or more modules are compiled without the
97+# KBUILD_MODNAME definition. The reason is that any made-up name would
98+# differ in different configs.
9999 name-fix = $(subst $(comma),_,$(subst -,_,$1))
100100 basename_flags = -D"KBUILD_BASENAME=KBUILD_STR($(call name-fix,$(basetarget)))"
101101 modname_flags = $(if $(filter 1,$(words $(modname))),\

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t