System topology on intel based system needs to be exported for non-numa case as well. All parts of asm-i386/topology.h has come under #ifdef CONFIG_NUMA after the merge to asm-x86/topology.h /sys/devices/system/cpu/cpu?/topology/* is populated based on ENABLE_TOPO_DEFINES The sysfs cpu topology is not being populated on my dual socket dual core xeon 5160 processor based (x86 32 bit) system. CONFIG_NUMA is not set in my case yet the topology is relevant and useful. irqbalance daemon application depends on topology to build the cpus and package list and it fails on Fedora9 beta since the sysfs topology was not being populated in the 2.6.25 kernel. I am not sure if it was intentional to not define ENABLE_TOPO_DEFINES for non-numa systems. This fix has been tested on the above mentioned dual core, dual socket system.
Unified · Split
| @@ -25,6 +25,16 @@ · 24 unmodified lines | ||
| 25 | 25 | #ifndef _ASM_X86_TOPOLOGY_H |
| 26 | 26 | #define _ASM_X86_TOPOLOGY_H |
| 27 | 27 | |
| 28 | +#ifdef CONFIG_X86_32 | |
| 29 | +# ifdef CONFIG_X86_HT | |
| 30 | +# define ENABLE_TOPO_DEFINES | |
| 31 | +# endif | |
| 32 | +#else | |
| 33 | +# ifdef CONFIG_SMP | |
| 34 | +# define ENABLE_TOPO_DEFINES | |
| 35 | +# endif | |
| 36 | +#endif | |
| 37 | + | |
| 28 | 38 | #ifdef CONFIG_NUMA |
| 29 | 39 | #include <linux/cpumask.h> |
| 30 | 40 | #include <asm/mpspec.h> |
| @@ -130,10 +140,6 @@ extern unsigned long node_end_pfn[]; · 99 unmodified lines | ||
| 130 | 140 | extern unsigned long node_remap_size[]; |
| 131 | 141 | #define node_has_online_mem(nid) (node_start_pfn[nid] != node_end_pfn[nid]) |
| 132 | 142 | |
| 133 | −# ifdef CONFIG_X86_HT | |
| 134 | −# define ENABLE_TOPO_DEFINES | |
| 135 | −# endif | |
| 136 | − | |
| 137 | 143 | # define SD_CACHE_NICE_TRIES 1 |
| 138 | 144 | # define SD_IDLE_IDX 1 |
| 139 | 145 | # define SD_NEWIDLE_IDX 2 |
| @@ -141,10 +147,6 @@ extern unsigned long node_remap_size[]; · 1 unmodified line | ||
| 141 | 147 | |
| 142 | 148 | #else |
| 143 | 149 | |
| 144 | −# ifdef CONFIG_SMP | |
| 145 | −# define ENABLE_TOPO_DEFINES | |
| 146 | −# endif | |
| 147 | − | |
| 148 | 150 | # define SD_CACHE_NICE_TRIES 2 |
| 149 | 151 | # define SD_IDLE_IDX 2 |
| 150 | 152 | # define SD_NEWIDLE_IDX 2 |