History

net/mlx5: Don't handle VF func change if host PF is disabled

When ECPF eswitch manager is at offloads mode, it monitors functions changed event from host PF side and acts according to the number of VFs enabled/disabled. As ECPF and host PF work in two independent hosts, it's possible that host PF OS reboots but ECPF system is still kept on and continues monitoring events from host PF. When kernel from host PF side is booting, PCI iov driver does sriov_init and compute_max_vf_buses by iterating over all valid num of VFs. This triggers FLR and generates functions changed events, even though host PF HCA is not enabled at this time. However, ECPF is not aware of this information, and still handles these events as usual. ECPF system will see massive number of reps are created, but destroyed immediately once creation finished. To eliminate this noise, a bit is added to host parameter context to indicate host PF is disabled. ECPF will not handle the VF changed event if this bit is set.

Bodong Wang committed 7 years ago

Commit 5ccf2771 parent 7e26dac2 files · +6 −2Browse files

Unified · Split

2 files
  1. drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c +4 −1
  2. include/linux/mlx5/mlx5_ifc.h +2 −1
drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c+4−1
@@ -2026,6 +2026,7 @@ static void esw_functions_changed_event_handler(struct work_struct *work) · 2025 unmodified lines
20262026 u32 out[MLX5_ST_SZ_DW(query_esw_functions_out)] = {};
20272027 struct mlx5_host_work *host_work;
20282028 struct mlx5_eswitch *esw;
2029+ bool host_pf_disabled;
20292030 u16 num_vfs = 0;
20302031 int err;
20312032
@@ -2035,7 +2036,9 @@ static void esw_functions_changed_event_handler(struct work_struct *work) · 3 unmodified lines
20352036 err = mlx5_esw_query_functions(esw->dev, out, sizeof(out));
20362037 num_vfs = MLX5_GET(query_esw_functions_out, out,
20372038 host_params_context.host_num_of_vfs);
2038− if (err || num_vfs == esw->esw_funcs.num_vfs)
2039+ host_pf_disabled = MLX5_GET(query_esw_functions_out, out,
2040+ host_params_context.host_pf_disabled);
2041+ if (err || host_pf_disabled || num_vfs == esw->esw_funcs.num_vfs)
20392042 goto out;
20402043
20412044 /* Number of VFs can only change from "0 to x" or "x to 0". */
include/linux/mlx5/mlx5_ifc.h+2−1
@@ -9823,7 +9823,8 @@ struct mlx5_ifc_mtrc_ctrl_bits { · 9822 unmodified lines
98239823
98249824 struct mlx5_ifc_host_params_context_bits {
98259825 u8 host_number[0x8];
9826− u8 reserved_at_8[0x8];
9826+ u8 reserved_at_8[0x7];
9827+ u8 host_pf_disabled[0x1];
98279828 u8 host_num_of_vfs[0x10];
98289829
98299830 u8 host_total_vfs[0x10];

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t