coccinelle: irqf_oneshot: reduce the severity due to false positives

The IRQF_ONESHOT should be present for threaded IRQ using default primary handler. However intetrupt of many child devices, e.g. children of MFD, is nested thus the IRQF_ONESHOT is not needed. The coccinelle message about error misleads submitters and reviewers about the severity of the issue, so make it a warning and mention possible false positive.

Krzysztof Kozlowski committed 5 years ago

Commit 5d2db9b1 parent 7845daa1 file · +2 −2Browse files

Showing the changes to scripts (1 of 1 file). Show all

Unified · Split

scripts/coccinelle/misc/irqf_oneshot.cocci+2−2

@@ -103,11 +103,11 @@ devm_request_threaded_irq@p(dev, irq, NULL, ...) · 102 unmodified lines
103	103	@script:python depends on org@
104	104	p << match.p;
105	105	@@
106		−msg = "ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT"
	106	+msg = "WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ)"
107	107	coccilib.org.print_todo(p[0],msg)
108	108
109	109	@script:python depends on report@
110	110	p << match.p;
111	111	@@
112		−msg = "ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT"
	112	+msg = "WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ)"
113	113	coccilib.report.print_report(p[0],msg)