History

kbuild: rebuild .vmlinux.export.o when its prerequisite is updated

When include/linux/export-internal.h is updated, .vmlinux.export.o must be rebuilt, but it does not happen because its rule is hidden behind scripts/link-vmlinux.sh. Move it out of the shell script, so that Make can see the dependency between vmlinux and .vmlinux.export.o. Move the vmlinux rule to scripts/Makefile.vmlinux.

Masahiro Yamada committed 4 years ago

Commit 5d4aeff1 parent 7a342e63 files · +25 −19Browse files

Unified · Split

3 files
  1. Makefile +5 −13
  2. scripts/Makefile.vmlinux +20 −1
  3. scripts/link-vmlinux.sh +0 −5
Makefile+5−13
@@ -502,7 +502,7 @@ AFLAGS_MODULE = · 501 unmodified lines
502502 LDFLAGS_MODULE =
503503 CFLAGS_KERNEL =
504504 AFLAGS_KERNEL =
505−LDFLAGS_vmlinux =
505+export LDFLAGS_vmlinux =
506506
507507 # Use USERINCLUDE when you must reference the UAPI directories only.
508508 USERINCLUDE := \
@@ -1160,17 +1160,9 @@ vmlinux_o: vmlinux.a $(KBUILD_VMLINUX_LIBS) · 651 unmodified lines
11601160 vmlinux.o modules.builtin.modinfo modules.builtin: vmlinux_o
11611161 @:
11621162
1163−ARCH_POSTLINK := $(wildcard $(srctree)/arch/$(SRCARCH)/Makefile.postlink)
1164−
1165−# Final link of vmlinux with optional arch pass after final link
1166−cmd_link-vmlinux = \
1167− $(CONFIG_SHELL) $< "$(LD)" "$(KBUILD_LDFLAGS)" "$(LDFLAGS_vmlinux)"; \
1168− $(if $(ARCH_POSTLINK), $(MAKE) -f $(ARCH_POSTLINK) $@, true)
1169−
1170−vmlinux: scripts/link-vmlinux.sh vmlinux.o $(KBUILD_LDS) modpost FORCE
1171− +$(call if_changed_dep,link-vmlinux)
1172−
1173−targets += vmlinux
1163+PHONY += vmlinux
1164+vmlinux: vmlinux.o $(KBUILD_LDS) modpost
1165+ $(Q)$(MAKE) -f $(srctree)/scripts/Makefile.vmlinux
11741166
11751167 # The actual objects are generated when descending,
11761168 # make sure no implicit rule kicks in
@@ -1501,7 +1493,7 @@ endif # CONFIG_MODULES · 324 unmodified lines
15011493 # Directories & files removed with 'make clean'
15021494 CLEAN_FILES += include/ksym vmlinux.symvers modules-only.symvers \
15031495 modules.builtin modules.builtin.modinfo modules.nsdeps \
1504− compile_commands.json .thinlto-cache .vmlinux.objs
1496+ compile_commands.json .thinlto-cache .vmlinux.objs .vmlinux.export.c
15051497
15061498 # Directories & files removed with 'make mrproper'
15071499 MRPROPER_FILES += include/config include/generated \
scripts/Makefile.vmlinux+20−1
@@ -1,18 +1,37 @@
11 # SPDX-License-Identifier: GPL-2.0-only
22
3+PHONY := __default
4+__default: vmlinux
5+
36 include include/config/auto.conf
47 include $(srctree)/scripts/Kbuild.include
58
69 # for c_flags
710 include $(srctree)/scripts/Makefile.lib
811
12+targets :=
13+
914 quiet_cmd_cc_o_c = CC $@
1015 cmd_cc_o_c = $(CC) $(c_flags) -c -o $@ $<
1116
1217 %.o: %.c FORCE
1318 $(call if_changed_dep,cc_o_c)
1419
15−targets := $(MAKECMDGOALS)
20+ifdef CONFIG_MODULES
21+targets += .vmlinux.export.o
22+vmlinux: .vmlinux.export.o
23+endif
24+
25+ARCH_POSTLINK := $(wildcard $(srctree)/arch/$(SRCARCH)/Makefile.postlink)
26+
27+# Final link of vmlinux with optional arch pass after final link
28+cmd_link_vmlinux = \
29+ $< "$(LD)" "$(KBUILD_LDFLAGS)" "$(LDFLAGS_vmlinux)"; \
30+ $(if $(ARCH_POSTLINK), $(MAKE) -f $(ARCH_POSTLINK) $@, true)
31+
32+targets += vmlinux
33+vmlinux: scripts/link-vmlinux.sh vmlinux.o $(KBUILD_LDS) FORCE
34+ +$(call if_changed_dep,link_vmlinux)
1635
1736 # Add FORCE to the prequisites of a target to force it to be always rebuilt.
1837 # ---------------------------------------------------------------------------
scripts/link-vmlinux.sh+0−5
@@ -199,7 +199,6 @@ cleanup() · 198 unmodified lines
199199 rm -f System.map
200200 rm -f vmlinux
201201 rm -f vmlinux.map
202− rm -f .vmlinux.export.c
203202 }
204203
205204 # Use "make V=1" to debug this script
@@ -214,10 +213,6 @@ if [ "$1" = "clean" ]; then · 8 unmodified lines
214213 exit 0
215214 fi
216215
217−if is_enabled CONFIG_MODULES; then
218− ${MAKE} -f "${srctree}/scripts/Makefile.vmlinux" .vmlinux.export.o
219−fi
220−
221216 ${MAKE} -f "${srctree}/scripts/Makefile.build" obj=init init/version-timestamp.o
222217
223218 btf_vmlinux_bin_o=""