History

blk-mq: remove the bio argument to ->prepare_request

None of the I/O schedulers actually needs it.

Christoph Hellwig committed 6 years ago

Commit 5d9c3051 parent 3382a565 files · +5 −5Browse files

Unified · Split

5 files
  1. block/bfq-iosched.c +1 −1
  2. block/blk-mq.c +1 −1
  3. block/kyber-iosched.c +1 −1
  4. block/mq-deadline.c +1 −1
  5. include/linux/elevator.h +1 −1
block/bfq-iosched.c+1−1
@@ -6073,7 +6073,7 @@ static struct bfq_queue *bfq_get_bfqq_handle_split(struct bfq_data *bfqd, · 6072 unmodified lines
60736073 * comments on bfq_init_rq for the reason behind this delayed
60746074 * preparation.
60756075 */
6076−static void bfq_prepare_request(struct request *rq, struct bio *bio)
6076+static void bfq_prepare_request(struct request *rq)
60776077 {
60786078 /*
60796079 * Regardless of whether we have an icq attached, we have to
block/blk-mq.c+1−1
@@ -387,7 +387,7 @@ static struct request *blk_mq_get_request(struct request_queue *q, · 386 unmodified lines
387387 if (e->type->icq_cache)
388388 blk_mq_sched_assign_ioc(rq);
389389
390− e->type->ops.prepare_request(rq, bio);
390+ e->type->ops.prepare_request(rq);
391391 rq->rq_flags |= RQF_ELVPRIV;
392392 }
393393 }
block/kyber-iosched.c+1−1
@@ -579,7 +579,7 @@ static bool kyber_bio_merge(struct blk_mq_hw_ctx *hctx, struct bio *bio, · 578 unmodified lines
579579 return merged;
580580 }
581581
582−static void kyber_prepare_request(struct request *rq, struct bio *bio)
582+static void kyber_prepare_request(struct request *rq)
583583 {
584584 rq_set_domain_token(rq, -1);
585585 }
block/mq-deadline.c+1−1
@@ -541,7 +541,7 @@ static void dd_insert_requests(struct blk_mq_hw_ctx *hctx, · 540 unmodified lines
541541 * Nothing to do here. This is defined only to ensure that .finish_request
542542 * method is called upon request completion.
543543 */
544−static void dd_prepare_request(struct request *rq, struct bio *bio)
544+static void dd_prepare_request(struct request *rq)
545545 {
546546 }
547547
include/linux/elevator.h+1−1
@@ -39,7 +39,7 @@ struct elevator_mq_ops { · 38 unmodified lines
3939 void (*request_merged)(struct request_queue *, struct request *, enum elv_merge);
4040 void (*requests_merged)(struct request_queue *, struct request *, struct request *);
4141 void (*limit_depth)(unsigned int, struct blk_mq_alloc_data *);
42− void (*prepare_request)(struct request *, struct bio *bio);
42+ void (*prepare_request)(struct request *);
4343 void (*finish_request)(struct request *);
4444 void (*insert_requests)(struct blk_mq_hw_ctx *, struct list_head *, bool);
4545 struct request *(*dispatch_request)(struct blk_mq_hw_ctx *);

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t