In ftrace_dump, for disabling buffer, iter.tr->trace_buffer.data is used. But for enabling, iter.trace_buffer->data is used. Even though, both point to same buffer, for readability, same convention should be used. Link: http://lkml.kernel.org/r/1434972306-20043-1-git-send-email-umesh.t@samsung.com
Showing the changes to kernel/trace (1 of 1 file). Show all
Unified · Split
| @@ -6990,7 +6990,7 @@ void ftrace_dump(enum ftrace_dump_mode oops_dump_mode) · 6989 unmodified lines | |||
| 6990 | trace_init_global_iter(&iter); | 6990 | trace_init_global_iter(&iter); |
| 6991 | 6991 | ||
| 6992 | for_each_tracing_cpu(cpu) { | 6992 | for_each_tracing_cpu(cpu) { |
| 6993 | atomic_inc(&per_cpu_ptr(iter.tr->trace_buffer.data, cpu)->disabled); | 6993 | atomic_inc(&per_cpu_ptr(iter.trace_buffer->data, cpu)->disabled); |
| 6994 | } | 6994 | } |
| 6995 | 6995 | ||
| 6996 | old_userobj = trace_flags & TRACE_ITER_SYM_USEROBJ; | 6996 | old_userobj = trace_flags & TRACE_ITER_SYM_USEROBJ; |