History

mmc: omap_hsmmc: remove prepare/complete system suspend support.

The only function of these 'prepare' and 'complete' is to disable the 'card detect' irq during suspend. The commit which added this, commit a48ce884d5819d5df2cf1139ab3c43f8e9e419b3 mmc: omap_hsmmc: Introduce omap_hsmmc_prepare/complete justified it by the need to avoid the registration of new devices during suspend. However mmc_pm_notify will set ->rescan_disable in the 'prepare' stage and clear it in the 'complete' stage, so no card detection will actually happen. Also the interrupt will be disabled before final suspend as part of common suspend processing. So this disabling of the interrupt is unnecessary, and interferes with a transition to using common code for card-detect management.

NeilBrown committed 11 years ago

Commit 61bd8a01 parent 8a66fda2 files · +0 −54Browse files

Showing the changes to include/linux/platform_data (1 of 2 files). Show all

Unified · Split

include/linux/platform_data/mmc-omap.h+0−4
@@ -31,10 +31,6 @@ struct omap_mmc_platform_data { · 30 unmodified lines
31 void (*cleanup)(struct device *dev);31 void (*cleanup)(struct device *dev);
32 void (*shutdown)(struct device *dev);32 void (*shutdown)(struct device *dev);
33 33
34 /* To handle board related suspend/resume functionality for MMC */
35 int (*suspend)(struct device *dev, int slot);
36 int (*resume)(struct device *dev, int slot);
37
38 /* Return context loss count due to PM states changing */34 /* Return context loss count due to PM states changing */
39 int (*get_context_loss_count)(struct device *dev);35 int (*get_context_loss_count)(struct device *dev);
40 36

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t