History

sched: Remove rcu_read_lock/unlock() from select_idle_sibling()

select_idle_sibling() is called from select_task_rq_fair(), which already has the RCU read lock held.

Nikunj A. Dadhania committed 14 years ago

Commit 62f65361 parent 9388dc31 file · +0 −4Browse files

Showing the changes to kernel (1 of 1 file). Show all

Unified · Split

kernel/sched/fair.c+0−4
@@ -2670,8 +2670,6 @@ static int select_idle_sibling(struct task_struct *p, int target) · 2669 unmodified lines
2670 /*2670 /*
2671 * Otherwise, iterate the domains and find an elegible idle cpu.2671 * Otherwise, iterate the domains and find an elegible idle cpu.
2672 */2672 */
2673 rcu_read_lock();
2674
2675 sd = rcu_dereference(per_cpu(sd_llc, target));2673 sd = rcu_dereference(per_cpu(sd_llc, target));
2676 for_each_lower_domain(sd) {2674 for_each_lower_domain(sd) {
2677 sg = sd->groups;2675 sg = sd->groups;
@@ -2693,8 +2691,6 @@ next: · 15 unmodified lines
2693 } while (sg != sd->groups);2691 } while (sg != sd->groups);
2694 }2692 }
2695done:2693done:
2696 rcu_read_unlock();
2697
2698 return target;2694 return target;
2699}2695}
2700 2696

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t