Pull smpboot bugfix from Thomas Gleixner: "A single bugfix for a regression introduced with the conversion of the stop machine threads to the generic smpboot thread management facility" * 'core-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip: stop_machine: Mark per cpu stopper enabled early
Unified · Split
| @@ -24,6 +24,9 @@ struct smpboot_thread_data; · 23 unmodified lines | ||
| 24 | 24 | * parked (cpu offline) |
| 25 | 25 | * @unpark: Optional unpark function, called when the thread is |
| 26 | 26 | * unparked (cpu online) |
| 27 | + * @pre_unpark: Optional unpark function, called before the thread is | |
| 28 | + * unparked (cpu online). This is not guaranteed to be | |
| 29 | + * called on the target cpu of the thread. Careful! | |
| 27 | 30 | * @selfparking: Thread is not parked by the park function. |
| 28 | 31 | * @thread_comm: The base name of the thread |
| 29 | 32 | */ |
| @@ -37,6 +40,7 @@ struct smp_hotplug_thread { · 7 unmodified lines | ||
| 37 | 40 | void (*cleanup)(unsigned int cpu, bool online); |
| 38 | 41 | void (*park)(unsigned int cpu); |
| 39 | 42 | void (*unpark)(unsigned int cpu); |
| 43 | + void (*pre_unpark)(unsigned int cpu); | |
| 40 | 44 | bool selfparking; |
| 41 | 45 | const char *thread_comm; |
| 42 | 46 | }; |
| @@ -209,6 +209,8 @@ static void smpboot_unpark_thread(struct smp_hotplug_thread *ht, unsigned int cp · 208 unmodified lines | ||
| 209 | 209 | { |
| 210 | 210 | struct task_struct *tsk = *per_cpu_ptr(ht->store, cpu); |
| 211 | 211 | |
| 212 | + if (ht->pre_unpark) | |
| 213 | + ht->pre_unpark(cpu); | |
| 212 | 214 | kthread_unpark(tsk); |
| 213 | 215 | } |
| 214 | 216 | |
| @@ -336,7 +336,7 @@ static struct smp_hotplug_thread cpu_stop_threads = { · 335 unmodified lines | ||
| 336 | 336 | .create = cpu_stop_create, |
| 337 | 337 | .setup = cpu_stop_unpark, |
| 338 | 338 | .park = cpu_stop_park, |
| 339 | − .unpark = cpu_stop_unpark, | |
| 339 | + .pre_unpark = cpu_stop_unpark, | |
| 340 | 340 | .selfparking = true, |
| 341 | 341 | }; |
| 342 | 342 | |